You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/05/14 05:51:00 UTC

[GitHub] [bookkeeper] lamber-ken opened a new pull request #2329: Fix wrong module artifactId

lamber-ken opened a new pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329


   ### Motivation
   
   Fix wrong maven artifactId, there are three module use the same artifactId.
   
   ### Changes
   
   ![image](https://user-images.githubusercontent.com/20113411/81897790-e4fe2180-95e9-11ea-9449-92941fe4c1bc.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] eolivelli edited a comment on pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329#issuecomment-628413011


   All tests failed on CI please check 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] eolivelli commented on pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329#issuecomment-628413011


   All tests facile on CI please check 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] eolivelli commented on pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329#issuecomment-629784283


   @rdhabalia @sijie @jiazhai  PTAL and merge
   IMO It is worth to backport to 4.10 branch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] lamber-ken commented on pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329#issuecomment-628415457


   > All tests failed on CI please check
   
   Welcome, not familiar with bookkeeper, I am checking the ci. : )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] sijie merged pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] eolivelli commented on pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329#issuecomment-629997757


   @rdhabalia @jiazhai can you please help merging this patch ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] lamber-ken commented on pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329#issuecomment-629685806


   @sijie @eolivelli please review again, thanks : )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] lamber-ken edited a comment on pull request #2329: Fix wrong module artifactId

Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #2329:
URL: https://github.com/apache/bookkeeper/pull/2329#issuecomment-629685806


   hi @sijie @eolivelli please review again, thanks : )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org