You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/08/11 16:27:36 UTC

[Impala-ASF-CR] IMPALA-11493: Fix docker-based run-workload.py test

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18833


Change subject: IMPALA-11493: Fix docker-based run-workload.py test
......................................................................

IMPALA-11493: Fix docker-based run-workload.py test

The run-workload.py smoke check runs as part of
the custom cluster test segment for docker-based
tests. This requires a running Impala cluster,
so this fixes run-all-tests.sh to start the
Impala cluster when CLUSTER_TEST=true.

Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18833/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11493: Fix docker-based run-workload.py test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18833 )

Change subject: IMPALA-11493: Fix docker-based run-workload.py test
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 21:37:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11493: Fix docker-based run-workload.py test

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18833 )

Change subject: IMPALA-11493: Fix docker-based run-workload.py test
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 04:16:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11493: Fix docker-based run-workload.py test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18833 )

Change subject: IMPALA-11493: Fix docker-based run-workload.py test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11147/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 16:49:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11493: Fix docker-based run-workload.py test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18833 )

Change subject: IMPALA-11493: Fix docker-based run-workload.py test
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8446/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 16:43:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11493: Fix docker-based run-workload.py test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18833 )

Change subject: IMPALA-11493: Fix docker-based run-workload.py test
......................................................................

IMPALA-11493: Fix docker-based run-workload.py test

The run-workload.py smoke check runs as part of
the custom cluster test segment for docker-based
tests. This requires a running Impala cluster,
so this fixes run-all-tests.sh to start the
Impala cluster when CLUSTER_TEST=true.

Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Reviewed-on: http://gerrit.cloudera.org:8080/18833
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11493: Fix docker-based run-workload.py test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18833 )

Change subject: IMPALA-11493: Fix docker-based run-workload.py test
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a07269ddf808c1470be86bb305ccf1120f4b81a
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 16:43:14 +0000
Gerrit-HasComments: No