[GitHub] [solr] justinrsweeney commented on a diff in pull request #948: SOLR-15007: Adding ability to provide aggregated node level metrics for request handlers

[GitBox <gi...@apache.org>]

justinrsweeney commented on code in PR #948:
URL: https://github.com/apache/solr/pull/948#discussion_r954069229


##########
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##########
@@ -131,6 +134,11 @@ public void init(NamedList<?> args) {
     if (initArgs != null) {
       Object caching = initArgs.get("httpCaching");
       httpCaching = caching != null ? Boolean.parseBoolean(caching.toString()) : true;
+      Boolean aggregateNodeLevelMetricsEnabled =

Review Comment:
   Assuming this is fairly minor, I left this as is since we are already using it so it'll save us a bit of work from having to switch it. If this is a blocker, let me know and I can change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org