You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by TAKLON STEPHEN WU <wu...@amazon.com> on 2016/07/25 23:12:42 UTC

Review Request 50424: Read properties files in action configurations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50424/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-2617
    https://issues.apache.org/jira/browse/OOZIE-2617


Repository: oozie-git


Description
-------

Current logic of acton configuration only READ xml files within Oozie action directory, but for pig and other applications, properties files are supported and may be default configuration file format. To simplify the logic of reusing these properties files when using Oozie with them, we add properties file reading in action conf.


Diffs
-----

  core/src/main/java/org/apache/oozie/service/ActionConfFileType.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java f171ea3 
  core/src/test/java/org/apache/oozie/service/TestActionConfFileType.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java bbe2594 

Diff: https://reviews.apache.org/r/50424/diff/


Testing
-------

$ cd oozie/core
$ mvn clean install -Dtest=TestHadoopAccessorService -Dtest=TestActionConfFileType

Running org.apache.oozie.service.TestActionConfFileType
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.493 sec
Running org.apache.oozie.service.TestHadoopAccessorService
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.003 sec

Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56.006 s
[INFO] Finished at: 2016-07-22T19:26:28-07:00
[INFO] Final Memory: 81M/1473M
[INFO] ------------------------------------------------------------------------


Thanks,

TAKLON STEPHEN WU


Re: Review Request 50424: Read properties files in action configurations

Posted by TAKLON STEPHEN WU <wu...@amazon.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50424/
-----------------------------------------------------------

(Updated Aug. 2, 2016, 9:37 p.m.)


Review request for oozie.


Changes
-------

updated twiki and comments inline


Bugs: OOZIE-2617
    https://issues.apache.org/jira/browse/OOZIE-2617


Repository: oozie-git


Description
-------

Current logic of acton configuration only READ xml files within Oozie action directory, but for pig and other applications, properties files are supported and may be default configuration file format. To simplify the logic of reusing these properties files when using Oozie with them, we add properties file reading in action conf.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/service/ActionConfFileType.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java f171ea3 
  core/src/test/java/org/apache/oozie/service/TestActionConfFileType.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java bbe2594 
  docs/src/site/twiki/AG_ActionConfiguration.twiki f8e6edc 

Diff: https://reviews.apache.org/r/50424/diff/


Testing
-------

$ cd oozie/core
$ mvn clean install -Dtest=TestHadoopAccessorService -Dtest=TestActionConfFileType

Running org.apache.oozie.service.TestActionConfFileType
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.493 sec
Running org.apache.oozie.service.TestHadoopAccessorService
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.003 sec

Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56.006 s
[INFO] Finished at: 2016-07-22T19:26:28-07:00
[INFO] Final Memory: 81M/1473M
[INFO] ------------------------------------------------------------------------


Thanks,

TAKLON STEPHEN WU