You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/12 09:16:56 UTC
[GitHub] [flink] zentol commented on a change in pull request #8654:
[FLINK-12647][network] Add feature flag to disable release of consumed
blocking partitions
zentol commented on a change in pull request #8654: [FLINK-12647][network] Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r292818393
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -209,6 +210,11 @@
.withDeprecatedKeys("taskmanager.net.request-backoff.max")
.withDescription("Maximum backoff in milliseconds for partition requests of input channels.");
+ @Documentation.ExcludeFromDocumentation("dev use only; likely temporary")
+ public static final ConfigOption<Boolean> RELEASE_EXTERNALLY_MANAGED_PARTITIONS_ON_CONSUMPTION =
+ key("taskmanager.network.partition.release-externally-managed-on-consumption")
Review comment:
We don't have to be consistent with the variable name. The `partition` is already contained in the key prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services