You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 03:53:41 UTC
[jira] [Created] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
--------------------------------------------------------------------------
Key: TS-1041
URL: https://issues.apache.org/jira/browse/TS-1041
Project: Traffic Server
Issue Type: Improvement
Components: DNS
Environment: Mac OS X 10.7
Reporter: James Peach
Priority: Minor
Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181520#comment-13181520 ]
James Peach commented on TS-1041:
---------------------------------
I never knew that sa_len and friends was a BSD-ism. Will need to add some autoconf.
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "James Peach (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach reassigned TS-1041:
-------------------------------
Assignee: Leif Hedstrom
Leif, can you please review and apply if it looks ok?
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "James Peach (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach reassigned TS-1041:
-------------------------------
Assignee: Leif Hedstrom (was: James Peach)
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0001-Ensure-sockaddr-length-is-always-populated.patch, 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "Igor Galić (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166050#comment-13166050 ]
Igor Galić commented on TS-1041:
--------------------------------
s/sa_len/sa_len|sin_len(6)/ ?
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Priority: Minor
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1041:
----------------------------
Attachment: 0001-Ensure-sockaddr-length-is-always-populated.patch
Updated patch that includes configure checks.
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Assignee: James Peach
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0001-Ensure-sockaddr-length-is-always-populated.patch, 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1041:
----------------------------
Attachment: 0003-Ensure-sockaddr-length-is-always-populated.patch
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Priority: Minor
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166332#comment-13166332 ]
James Peach commented on TS-1041:
---------------------------------
I was referring to the sockaddr you get from TSHostLookupResultAddrGet(), where you look at sa_len to figure out how many bytes to copy.
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Priority: Minor
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "James Peach (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach reassigned TS-1041:
-------------------------------
Assignee: James Peach (was: Leif Hedstrom)
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Assignee: James Peach
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181470#comment-13181470 ]
Leif Hedstrom commented on TS-1041:
-----------------------------------
{code}
In file included from ../../lib/ts/ink_resolver.h:73:0,
from ../../lib/ts/libts.h:71,
from P_EventSystem.h:39,
from EventSystem.cc:31:
../../lib/ts/ink_inet.h: In function ‘bool ink_inet_copy(sockaddr*, const sockaddr*)’:
../../lib/ts/ink_inet.h:510:10: error: ‘struct sockaddr’ has no member named ‘sa_len’
In file included from ../../lib/ts/ink_resolver.h:73:0,
from ../../lib/ts/libts.h:71,
from P_EventSystem.h:39,
from EventSystem.cc:31:
../../lib/ts/ink_inet.h: In function ‘sockaddr* ink_inet_ip4_set(sockaddr_in*, unsigned int, uint16_t)’:
../../lib/ts/ink_inet.h:665:8: error: ‘struct sockaddr_in’ has no member named ‘sin_len’
../../lib/ts/ink_inet.h: In function ‘sockaddr* ink_inet_ip6_set(sockaddr_in6*, const in6_addr&, uint16_t)’:
../../lib/ts/ink_inet.h:704:8: error: ‘struct sockaddr_in6’ has no member named ‘sin6_len’
{code}
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1041) PATCH: guarantee to populate sockaddr
length for TSHostLookupResultAddrGet
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1041:
------------------------------
Fix Version/s: 3.1.2
> PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet
> --------------------------------------------------------------------------
>
> Key: TS-1041
> URL: https://issues.apache.org/jira/browse/TS-1041
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Environment: Mac OS X 10.7
> Reporter: James Peach
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0003-Ensure-sockaddr-length-is-always-populated.patch
>
>
> The sockaddr returned by TSHostLookupResultAddrGet() does not always get it's sa_len field populated correctly. This patch guarantees to populate it to the correct value so that plugin authors can rely on that field when copying the TSHostLookupResultAddrGet() result.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira