You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/07 05:25:35 UTC
[GitHub] [incubator-mxnet] leezu opened a new issue #17988: Row-sparse
constant initializer accesses out of bound elements
leezu opened a new issue #17988: Row-sparse constant initializer accesses out of bound elements
URL: https://github.com/apache/incubator-mxnet/issues/17988
## Description
CI with updated toolchain (ie #17984) catches the bug.
`vector: :_M_range_check: __n (which is 4) >= this->size() (which is 4)`
### Error Message
## To Reproduce
Build with this simple patch
``` diff
diff --git a/src/c_api/c_api_executor.cc b/src/c_api/c_api_executor.cc
index afc64f73d..41193b596 100644
--- a/src/c_api/c_api_executor.cc
+++ b/src/c_api/c_api_executor.cc
@@ -809,7 +809,7 @@ int _SimpleBindImpl(SymbolHandle symbol_handle,
ret->ret_vec_charp.push_back(ret->ret_vec_str.back().c_str());
}
*shared_buffer_len = shared_buffer_map.size();
- *updated_shared_buffer_handle_list = &(ret->ret_handles[nd_idx]);
+ *updated_shared_buffer_handle_list = &(ret->ret_handles.at(nd_idx));
*updated_shared_buffer_name_list = &(ret->ret_vec_charp[0]);
}
```
OR follow the instructions in https://github.com/apache/incubator-mxnet/issues/17987 to trigger this via glibc assertions in debug build.
Wonder if this is related to https://github.com/apache/incubator-mxnet/issues/14189
CC: @eric-haibin-lin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17988: Row-sparse
constant initializer accesses out of bound elements
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17988: Row-sparse constant initializer accesses out of bound elements
URL: https://github.com/apache/incubator-mxnet/issues/17988#issuecomment-614188496
@eric-haibin-lin do you plan to fix this bug and reenable the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #17988:
Row-sparse constant initializer accesses out of bound elements
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin commented on issue #17988: Row-sparse constant initializer accesses out of bound elements
URL: https://github.com/apache/incubator-mxnet/issues/17988#issuecomment-614937598
Did the fix in https://github.com/apache/incubator-mxnet/pull/17762 not help?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17988: Row-sparse
constant initializer accesses out of bound elements
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17988: Row-sparse constant initializer accesses out of bound elements
URL: https://github.com/apache/incubator-mxnet/issues/17988#issuecomment-610520256
Also affects `test_rsp_const_init` in the Perl test suite
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu edited a comment on issue #17988:
Row-sparse constant initializer accesses out of bound elements
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on issue #17988: Row-sparse constant initializer accesses out of bound elements
URL: https://github.com/apache/incubator-mxnet/issues/17988#issuecomment-614944263
#17762 fixed an unrelated issue. You can build latest master from source and run `test_init.test_rsp_const_init` to verify the still unresolved bug in rsp code. Though `test_init.test_rsp_const_init` is currently disabled, so you need to enable it locally again first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17988: Row-sparse
constant initializer accesses out of bound elements
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17988: Row-sparse constant initializer accesses out of bound elements
URL: https://github.com/apache/incubator-mxnet/issues/17988#issuecomment-614944263
#17762 fixed an unrelated issue. You can build latest master from source and run `test_init.test_rsp_const_init` to verify the still unresolved bug in rsp code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on issue #17988: Row-sparse constant initializer accesses out of bound elements
Posted by GitBox <gi...@apache.org>.
szha commented on issue #17988:
URL: https://github.com/apache/incubator-mxnet/issues/17988#issuecomment-663913199
this is due to a shared buffer bug that #18219 addresses. it affects only v1.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org