You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/04/29 02:31:40 UTC
[PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Roiocam opened a new pull request, #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193#discussion_r1582701952
##########
build.sbt:
##########
@@ -61,7 +61,6 @@ lazy val cassandraBundle = project
libraryDependencies += ("org.apache.cassandra" % "cassandra-all" % "3.11.3")
.exclude("commons-logging", "commons-logging"),
dependencyOverrides += "com.github.jbellis" % "jamm" % "0.3.3", // See jamm comment in https://issues.apache.org/jira/browse/CASSANDRA-9608
- assembly / target := target.value / "bundle" / "pekko" / "persistence" / "cassandra" / "launcher",
Review Comment:
We could keep the same path, but `sbt-assembly` seems like has a bug. https://github.com/sbt/sbt-assembly/issues/503
We could open an issue for this, and then after sbt-assembly release, we could fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193#issuecomment-2081840815
@raboof would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193#discussion_r1582701952
##########
build.sbt:
##########
@@ -61,7 +61,6 @@ lazy val cassandraBundle = project
libraryDependencies += ("org.apache.cassandra" % "cassandra-all" % "3.11.3")
.exclude("commons-logging", "commons-logging"),
dependencyOverrides += "com.github.jbellis" % "jamm" % "0.3.3", // See jamm comment in https://issues.apache.org/jira/browse/CASSANDRA-9608
- assembly / target := target.value / "bundle" / "pekko" / "persistence" / "cassandra" / "launcher",
Review Comment:
We could keep the same path, but `sbt-assembly` seems like has a bug. https://github.com/sbt/sbt-assembly/issues/503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193#discussion_r1582640392
##########
build.sbt:
##########
@@ -61,7 +61,6 @@ lazy val cassandraBundle = project
libraryDependencies += ("org.apache.cassandra" % "cassandra-all" % "3.11.3")
.exclude("commons-logging", "commons-logging"),
dependencyOverrides += "com.github.jbellis" % "jamm" % "0.3.3", // See jamm comment in https://issues.apache.org/jira/browse/CASSANDRA-9608
- assembly / target := target.value / "bundle" / "pekko" / "persistence" / "cassandra" / "launcher",
Review Comment:
thanks for looking into this! while you could say moving the jar around would be an incompatible change, on the other hand you could say the bundle is a testkit component anyway, and we don't promise compatibility for testkit components (https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html), so this might be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193#issuecomment-2081839930
we start testing. ready to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193#discussion_r1582754663
##########
build.sbt:
##########
@@ -61,7 +61,6 @@ lazy val cassandraBundle = project
libraryDependencies += ("org.apache.cassandra" % "cassandra-all" % "3.11.3")
.exclude("commons-logging", "commons-logging"),
dependencyOverrides += "com.github.jbellis" % "jamm" % "0.3.3", // See jamm comment in https://issues.apache.org/jira/browse/CASSANDRA-9608
- assembly / target := target.value / "bundle" / "pekko" / "persistence" / "cassandra" / "launcher",
Review Comment:
OK, let we moving on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193#discussion_r1582705831
##########
build.sbt:
##########
@@ -61,7 +61,6 @@ lazy val cassandraBundle = project
libraryDependencies += ("org.apache.cassandra" % "cassandra-all" % "3.11.3")
.exclude("commons-logging", "commons-logging"),
dependencyOverrides += "com.github.jbellis" % "jamm" % "0.3.3", // See jamm comment in https://issues.apache.org/jira/browse/CASSANDRA-9608
- assembly / target := target.value / "bundle" / "pekko" / "persistence" / "cassandra" / "launcher",
Review Comment:
oh interesting! as said, changing the path might be fine given it's a test component, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update sbt-multi-jvm & sbt-assembly [pekko-persistence-cassandra]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #193:
URL: https://github.com/apache/pekko-persistence-cassandra/pull/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org