You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by apiri <gi...@git.apache.org> on 2016/04/08 22:16:23 UTC

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi-minifi/pull/7

    MINIFI-2 MINIFI-4 Configuration change notifier and listener

    MINIFI-2
    MINIFI-4
    Providing Configuration change notifier and listener interfaces with accompanying File implementation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/nifi-minifi MINIFI-4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 50ed9bf9ad86729379f72b8d5f2c694244764054
Author: Aldrin Piri <al...@apache.org>
Date:   2016-04-08T18:59:58Z

    MINIFI-2 MINIFI-4 Establishing a base implementation of the configuration change listener and notification services as well as a File implementation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59110902
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/test/java/org/apache/nifi/minifi/configuration/TestFileChangeNotifier.java ---
    @@ -0,0 +1,83 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +import java.nio.file.Paths;
    +
    +import org.junit.After;
    +import org.junit.Assert;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.Mockito;
    +
    +public class TestFileChangeNotifier {
    --- End diff --
    
    Certainly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59110901
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/main/java/org/apache/nifi/minifi/configuration/FileChangeNotifier.java ---
    @@ -0,0 +1,139 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +import static java.nio.file.StandardWatchEventKinds.ENTRY_MODIFY;
    +
    +import java.io.Closeable;
    +import java.io.File;
    +import java.io.IOException;
    +import java.nio.file.FileSystems;
    +import java.nio.file.Path;
    +import java.nio.file.WatchEvent;
    +import java.nio.file.WatchKey;
    +import java.nio.file.WatchService;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import java.util.Set;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.ScheduledExecutorService;
    +import java.util.concurrent.TimeUnit;
    +
    +/**
    + * FileChangeNotifier provides a simple FileSystem monitor for detecting changes for a specified file as generated from its corresponding {@link Path}.  Upon modifications to the associated file,
    + * associated listeners receive notification of a change allowing configuration logic to be reanalyzed.  The backing implementation is associated with a {@link ScheduledExecutorService} that
    + * ensures continuity of monitoring.
    + */
    +public class FileChangeNotifier implements ConfigurationChangeNotifier, Closeable {
    +
    +    private final ExecutorService executorService;
    +    private final Path configFile;
    +    private final WatchService configFileWatcher;
    +    private final Set<ConfigurationChangeListener> configurationChangeListeners = new HashSet<>();
    +
    +    private static final int DEFAULT_POLLING_PERIOD_INTERVAL = 15;
    +    private static final TimeUnit DEFAULT_POLLING_PERIOD_UNIT = TimeUnit.SECONDS;
    +
    +    /**
    +     * @param configFile to monitor for changes
    +     * @throws IOException if there are any issues with accessing the specified config file or generating the associated {@link WatchService}.
    +     */
    +    public FileChangeNotifier(Path configFile) throws IOException {
    +        final File file = configFile.toFile();
    +        if (!file.exists() || !file.canRead() || !file.isFile()) {
    +            throw new IllegalArgumentException(String.format("The specified path %s must be a readable file.", configFile));
    --- End diff --
    
    Not sure about this one.  On the one hand I feel like the start up process need some initial value for configuration that likely falls out of the purview of the change notifier.  Will contemplate a bit more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59427453
  
    --- Diff: minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeNotifier.java ---
    @@ -21,6 +21,11 @@
     public interface ConfigurationChangeNotifier {
     
         /**
    +     * Begins the associated notification service provided by the given implementation.  In most implementations, no action will occur until this method is invoked.
    +     */
    +    void initialize();
    --- End diff --
    
    Actually, given that this is a separate task, how would you feel about initialize in its current context being a #start method and then #initialize providing the properties as discussed? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59087047
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/test/java/org/apache/nifi/minifi/configuration/TestFileChangeNotifier.java ---
    @@ -0,0 +1,83 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +import java.nio.file.Paths;
    +
    +import org.junit.After;
    +import org.junit.Assert;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.Mockito;
    +
    +public class TestFileChangeNotifier {
    --- End diff --
    
    Could a unit be added to test the watcher notifying when a config file gets changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59085169
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/main/java/org/apache/nifi/minifi/configuration/FileChangeNotifier.java ---
    @@ -0,0 +1,139 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +import static java.nio.file.StandardWatchEventKinds.ENTRY_MODIFY;
    +
    +import java.io.Closeable;
    +import java.io.File;
    +import java.io.IOException;
    +import java.nio.file.FileSystems;
    +import java.nio.file.Path;
    +import java.nio.file.WatchEvent;
    +import java.nio.file.WatchKey;
    +import java.nio.file.WatchService;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import java.util.Set;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.ScheduledExecutorService;
    +import java.util.concurrent.TimeUnit;
    +
    +/**
    + * FileChangeNotifier provides a simple FileSystem monitor for detecting changes for a specified file as generated from its corresponding {@link Path}.  Upon modifications to the associated file,
    + * associated listeners receive notification of a change allowing configuration logic to be reanalyzed.  The backing implementation is associated with a {@link ScheduledExecutorService} that
    + * ensures continuity of monitoring.
    + */
    +public class FileChangeNotifier implements ConfigurationChangeNotifier, Closeable {
    +
    +    private final ExecutorService executorService;
    +    private final Path configFile;
    +    private final WatchService configFileWatcher;
    +    private final Set<ConfigurationChangeListener> configurationChangeListeners = new HashSet<>();
    +
    +    private static final int DEFAULT_POLLING_PERIOD_INTERVAL = 15;
    +    private static final TimeUnit DEFAULT_POLLING_PERIOD_UNIT = TimeUnit.SECONDS;
    +
    +    /**
    +     * @param configFile to monitor for changes
    +     * @throws IOException if there are any issues with accessing the specified config file or generating the associated {@link WatchService}.
    +     */
    +    public FileChangeNotifier(Path configFile) throws IOException {
    +        final File file = configFile.toFile();
    +        if (!file.exists() || !file.canRead() || !file.isFile()) {
    +            throw new IllegalArgumentException(String.format("The specified path %s must be a readable file.", configFile));
    --- End diff --
    
    Should it be a valid state to start with no config file and wait for it to be put there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59085011
  
    --- Diff: minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeListener.java ---
    @@ -0,0 +1,30 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +/**
    + * Interface for handling events detected and driven by an associated {@link ConfigurationChangeNotifier} to which the listener
    + * has registered via {@link ConfigurationChangeNotifier#registerListener(ConfigurationChangeListener)}.
    + */
    +public interface ConfigurationChangeListener {
    +
    +    /**
    +     * Provides a mechanism for the implementation to interpret the specified
    +     */
    +    void handleChange();
    --- End diff --
    
    How will the ConfigurationChangeNotifier let the listeners know what the configuration changed to?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59425771
  
    --- Diff: minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeNotifier.java ---
    @@ -21,6 +21,11 @@
     public interface ConfigurationChangeNotifier {
     
         /**
    +     * Begins the associated notification service provided by the given implementation.  In most implementations, no action will occur until this method is invoked.
    +     */
    +    void initialize();
    --- End diff --
    
    This should pass a Properties object so that change notifiers can be configured. The user would add properties to the bootstrap.conf (in the same way NiFi has notification services configured there) and RunMiNiFi would pass the bootstrap properties to each Change Notifier. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59426270
  
    --- Diff: minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeNotifier.java ---
    @@ -21,6 +21,11 @@
     public interface ConfigurationChangeNotifier {
     
         /**
    +     * Begins the associated notification service provided by the given implementation.  In most implementations, no action will occur until this method is invoked.
    +     */
    +    void initialize();
    --- End diff --
    
    I can dig that.  Will add.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59110888
  
    --- Diff: minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeListener.java ---
    @@ -0,0 +1,30 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +/**
    + * Interface for handling events detected and driven by an associated {@link ConfigurationChangeNotifier} to which the listener
    + * has registered via {@link ConfigurationChangeNotifier#registerListener(ConfigurationChangeListener)}.
    + */
    +public interface ConfigurationChangeListener {
    +
    +    /**
    +     * Provides a mechanism for the implementation to interpret the specified
    +     */
    +    void handleChange();
    --- End diff --
    
    Fair point on this one.  I was thinking a bit narrowly on the file case, but providing an InputStream to the consumer (in this case bootstrap) should provide some nice flexibility on both sides of the process.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59448506
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/main/java/org/apache/nifi/minifi/configuration/FileChangeNotifier.java ---
    @@ -42,33 +43,18 @@
      */
     public class FileChangeNotifier implements Runnable, ConfigurationChangeNotifier, Closeable {
     
    +    private Path configFile;
    +    private WatchService watchService;
    +    private long pollingSeconds;
    +
         private final ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
    -    private final Path configFile;
    -    private final WatchService watchService;
         private final Set<ConfigurationChangeListener> configurationChangeListeners = new HashSet<>();
     
    -    private static final int DEFAULT_POLLING_PERIOD_INTERVAL = 15;
    -    private static final TimeUnit DEFAULT_POLLING_PERIOD_UNIT = TimeUnit.SECONDS;
    -
    -    /**
    -     * @param configFile to monitor for changes
    -     * @throws IOException if there are any issues with accessing the specified config file or generating the associated {@link WatchService}.
    -     */
    -    public FileChangeNotifier(Path configFile) throws IOException {
    -        this(configFile, initializeWatcher(configFile));
    -    }
    -
    -
    -    public FileChangeNotifier(Path configFile, WatchService watchService) {
    -        final File file = configFile.toFile();
    -        if (!file.exists() || !file.canRead() || !file.isFile()) {
    -            throw new IllegalArgumentException(String.format("The specified path %s must be a readable file.", configFile));
    -        }
    -
    -        this.configFile = configFile;
    -        this.watchService = watchService;
    -    }
    +    protected static final String CONFIG_FILE_PATH_KEY = "nifi.notifier.file.config.path";
    +    protected static final String POLLING_PERIOD_INTERVAL_KEY = "nifi.notifier.file.polling.period.seconds";
    --- End diff --
    
    Should include "minifi" either by replacing "nifi" with it or by adding it subsequently. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59144065
  
    --- Diff: minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeListener.java ---
    @@ -0,0 +1,30 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.configuration;
    +
    +/**
    + * Interface for handling events detected and driven by an associated {@link ConfigurationChangeNotifier} to which the listener
    + * has registered via {@link ConfigurationChangeNotifier#registerListener(ConfigurationChangeListener)}.
    + */
    +public interface ConfigurationChangeListener {
    +
    +    /**
    +     * Provides a mechanism for the implementation to interpret the specified
    +     */
    +    void handleChange();
    --- End diff --
    
    That works for me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request: MINIFI-2 MINIFI-4 Configuration change n...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/7#discussion_r59429946
  
    --- Diff: minifi-api/src/main/java/org/apache/nifi/minifi/configuration/ConfigurationChangeNotifier.java ---
    @@ -21,6 +21,11 @@
     public interface ConfigurationChangeNotifier {
     
         /**
    +     * Begins the associated notification service provided by the given implementation.  In most implementations, no action will occur until this method is invoked.
    +     */
    +    void initialize();
    --- End diff --
    
    That works for me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---