You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2026/05/09 07:49:44 UTC
[PR] Fix 0509 [doris]
Gabriel39 opened a new pull request, #63102:
URL: https://github.com/apache/doris/pull/63102
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4416993668
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Fix 0509 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4411948110
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #63102:
URL: https://github.com/apache/doris/pull/63102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4412361790
# BE Regression && UT Coverage Report
Increment line coverage `33.33% (37/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63102_09adfa5b3b94854daee572c408c56c46bf6b38a3_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63102_09adfa5b3b94854daee572c408c56c46bf6b38a3_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.68% (27807/37738) |
| Line Coverage | 57.58% (300864/522475) |
| Region Coverage | 54.86% (251084/457672) |
| Branch Coverage | 56.34% (108396/192399) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Fix 0509 [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4411948952
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4412145952
<details>
<summary>TPC-H: <b>Total hot run time: 30027 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 09adfa5b3b94854daee572c408c56c46bf6b38a3, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 18148 4219 4028 4028
q2 q3 10711 887 610 610
q4 4658 468 343 343
q5 7466 1348 1151 1151
q6 186 170 142 142
q7 935 966 763 763
q8 9330 1414 1303 1303
q9 5583 5383 5371 5371
q10 6260 2082 1849 1849
q11 464 271 264 264
q12 639 416 311 311
q13 18090 3317 2804 2804
q14 290 291 262 262
q15 q16 866 865 796 796
q17 996 1113 722 722
q18 6518 5752 5616 5616
q19 1177 1243 1050 1050
q20 530 407 267 267
q21 4642 2432 2034 2034
q22 476 401 341 341
Total cold run time: 97965 ms
Total hot run time: 30027 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4764 4739 4783 4739
q2 q3 4671 4778 4191 4191
q4 2157 2174 1421 1421
q5 5013 5033 5352 5033
q6 201 170 137 137
q7 2057 1819 1606 1606
q8 3333 3153 3105 3105
q9 8477 8547 8472 8472
q10 4528 4500 4278 4278
q11 616 425 423 423
q12 692 759 523 523
q13 3282 3572 2918 2918
q14 325 318 273 273
q15 q16 939 788 722 722
q17 1328 1299 1279 1279
q18 8187 7135 7079 7079
q19 1159 1152 1118 1118
q20 2230 2217 1950 1950
q21 6200 5482 4884 4884
q22 550 515 443 443
Total cold run time: 60709 ms
Total hot run time: 54594 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4412354846
# BE UT Coverage Report
Increment line coverage `21.62% (24/111)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/09adfa5b3b94854daee572c408c56c46bf6b38a3_09adfa5b3b94854daee572c408c56c46bf6b38a3/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/09adfa5b3b94854daee572c408c56c46bf6b38a3_09adfa5b3b94854daee572c408c56c46bf6b38a3/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.52% (20631/38546) |
| Line Coverage | 37.16% (194778/524150) |
| Region Coverage | 33.51% (151931/453421) |
| Branch Coverage | 34.54% (66254/191828) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4412171524
<details>
<summary>TPC-DS: <b>Total hot run time: 172041 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 09adfa5b3b94854daee572c408c56c46bf6b38a3, data reload: false
query5 4303 656 514 514
query6 334 226 202 202
query7 4312 564 317 317
query8 336 232 214 214
query9 8846 4079 4049 4049
query10 458 339 306 306
query11 5771 2406 2184 2184
query12 183 140 129 129
query13 1287 616 437 437
query14 6015 5393 5092 5092
query14_1 4376 4370 4382 4370
query15 214 208 213 208
query16 959 448 423 423
query17 1071 745 618 618
query18 2439 484 346 346
query19 223 213 177 177
query20 138 137 133 133
query21 216 139 123 123
query22 13669 13981 14499 13981
query23 17316 16599 16194 16194
query23_1 16262 16312 16346 16312
query24 7371 1736 1319 1319
query24_1 1338 1336 1346 1336
query25 569 485 425 425
query26 1296 318 167 167
query27 2725 601 323 323
query28 4463 1959 1935 1935
query29 986 622 527 527
query30 299 235 203 203
query31 1091 1050 921 921
query32 80 71 68 68
query33 517 341 296 296
query34 1177 1123 638 638
query35 762 817 662 662
query36 1317 1328 1139 1139
query37 147 100 90 90
query38 3188 3155 3063 3063
query39 923 931 882 882
query39_1 868 896 874 874
query40 234 154 135 135
query41 61 61 56 56
query42 107 107 104 104
query43 323 322 287 287
query44
query45 206 202 187 187
query46 1071 1183 714 714
query47 2309 2305 2175 2175
query48 402 412 301 301
query49 635 515 419 419
query50 704 285 214 214
query51 4374 4295 4206 4206
query52 104 104 93 93
query53 257 286 213 213
query54 318 271 252 252
query55 92 89 91 89
query56 291 312 303 303
query57 1409 1376 1287 1287
query58 299 266 272 266
query59 1585 1653 1471 1471
query60 356 341 336 336
query61 157 160 163 160
query62 671 614 538 538
query63 255 202 205 202
query64 2415 842 677 677
query65
query66 1736 519 426 426
query67 30104 30025 29937 29937
query68
query69 454 348 327 327
query70 1025 1053 972 972
query71 325 310 282 282
query72 3119 2949 2641 2641
query73 841 758 443 443
query74 5087 4905 4767 4767
query75 2817 2707 2352 2352
query76 2290 1139 761 761
query77 429 419 364 364
query78 13238 12952 12580 12580
query79 2817 926 779 779
query80 1767 591 493 493
query81 523 278 238 238
query82 971 156 120 120
query83 346 278 248 248
query84 264 141 108 108
query85 906 511 452 452
query86 453 318 324 318
query87 3432 3362 3213 3213
query88 3553 2684 2661 2661
query89 443 381 342 342
query90 1883 202 181 181
query91 184 172 144 144
query92 76 75 76 75
query93 1244 952 548 548
query94 723 330 293 293
query95 682 470 359 359
query96 1082 748 320 320
query97 2689 2719 2549 2549
query98 241 238 228 228
query99 1080 1137 986 986
Total cold run time: 256292 ms
Total hot run time: 172041 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4411969088
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4411962513
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](parquet) Fix parquet row group column lookup crash and row group reader lifetime [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63102:
URL: https://github.com/apache/doris/pull/63102#issuecomment-4416993583
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org