You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/08/28 19:40:39 UTC

[GitHub] [beam] Abacn commented on pull request #28174: Fix a bug that maxConnections is Short in config but read back as Integer

Abacn commented on PR #28174:
URL: https://github.com/apache/beam/pull/28174#issuecomment-1696272215

   > @Abacn Can you please take a look? You have more context here.
   > 
   > I can see that `maxConnections` is `FieldType.INT16`, but in the `JdbcIO` it's an Integer. Maybe we should make it `INT32` instead?
   
   Yeah, the bug indicates the usage of `INT32` is error prone -- however, change it to INT32 is equivalently error prone either. Many places need to be in sync


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org