You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/08/03 10:42:34 UTC
[Bug 59934] New: Css Parser: fix race condition and poor concurrency
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
Bug ID: 59934
Summary: Css Parser: fix race condition and poor concurrency
Product: JMeter
Version: 3.0
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: HTTP
Assignee: issues@jmeter.apache.org
Reporter: loisel.jerome@gmail.com
The CssParser has several issues:
- race condition: several threads can compute the same CSS simultaneously when
not cached yet,
- poor concurrency: synchronized map has poor concurrency level compared to
guava's LoadingCache (which has similar concurrency performance when compared
to ConcurrentHashMap).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #5 from Felix Schumacher <fe...@internetallee.de> ---
@Jerome and all others involved in this. Thanks for your contribution.
Date: Sun Nov 27 13:35:45 2016
New Revision: 1771589
URL: http://svn.apache.org/viewvc?rev=1771589&view=rev
Log:
Fix race-conditions in CssParser.
Based on a patch by Jerome Loisel (loisel.jerome at gmail.com)
This closes github pr #221
Bugzilla Id: 59934
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Nov 27 15:39:42 2016
New Revision: 1771603
URL: http://svn.apache.org/viewvc?rev=1771603&view=rev
Log:
Bug 59934 - CSSParser: several threads can compute the same CSS simultaneously
when not cached yet (nightly build after 3.0)
Fix compilation error
Bugzilla Id: 59934
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/CssParser.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
--- Comment #3 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 34483
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34483&action=edit
Add Iterable interface to URLCollection to get even nearer to PR #221
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] Css Parser: fix race condition and poor concurrency
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
--- Comment #1 from Jerome <lo...@gmail.com> ---
Github pull request:
https://github.com/apache/jmeter/pull/221
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 34480
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34480&action=edit
Patch based on PR #221 using caffeine
I tried to adapt PR #221 to caffeine, as discussed on that PR.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
Summary|Css Parser: fix race |CSSParser: several threads
|condition and poor |can compute the same CSS
|concurrency |simultaneously when not
| |cached yet (nightly build
| |after 3.0)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] Css Parser: fix race condition and poor concurrency
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Linux |All
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
+1 for commit, thanks Felix (and Jérôme)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Nov 27 16:16:06 2016
New Revision: 1771604
URL: http://svn.apache.org/viewvc?rev=1771604&view=rev
Log:
Bug 59934 - CSSParser: several threads can compute the same CSS simultaneously
when not cached yet (nightly build after 3.0)
ignore caffeine
Bugzilla Id: 59934
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59934] CSSParser: several threads can compute the same CSS
simultaneously when not cached yet (nightly build after 3.0)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59934
--- Comment #8 from Felix Schumacher <fe...@internetallee.de> ---
Date: Sun Nov 27 18:08:57 2016
New Revision: 1771619
URL: http://svn.apache.org/viewvc?rev=1771619&view=rev
Log:
Add missing license file for caffeine. Bugzilla Id: 59934
Added:
jmeter/trunk/licenses/bin/caffeine-2.3.5.txt
--
You are receiving this mail because:
You are the assignee for the bug.