You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/06/20 15:54:09 UTC
[GitHub] brodybits opened a new pull request #455: Start 8.0.0-dev in master
brodybits opened a new pull request #455: Start 8.0.0-dev in master
URL: https://github.com/apache/cordova-android/pull/455
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Set version to 8.0.0-dev via coho
This is definitely needed since node 4 support was dropped from CI and we would like to avoid double revert that would be needed to continue with a minor release in master.
I would like to go ahead with this asap, will wait for an approval for up to 12 hours. I would prefer to merge this myself, no squash merge or extra merge commit please.
I would be happy to start 7.2.x branch if wanted to ship the existing changes in a minor release, do not personally see the value of this. We could always ship a patch release with cherry-pick of existing bug fixes if really needed for any reason.
Just like #454 I had to use a custom version of cordova-coho with a local patches to get it to work in my workarea, hoping to fix cordova-coho someday in the future.
### What testing has been done on this change?
-
### Checklist
- ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~
- ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~
- ~~Added automated test coverage as appropriate for this change.~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org