You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by seancxmao <gi...@git.apache.org> on 2018/04/20 07:27:07 UTC
[GitHub] spark pull request #21113: [SPARK-13136][SQL][FOLLOW-UP] Fix comment
GitHub user seancxmao opened a pull request:
https://github.com/apache/spark/pull/21113
[SPARK-13136][SQL][FOLLOW-UP] Fix comment
## What changes were proposed in this pull request?
Fix comment. Change `BroadcastHashJoin.broadcastFuture` to `BroadcastExchange.relationFuture`: https://github.com/apache/spark/blob/d28d5732ae205771f1f443b15b10e64dcffb5ff0/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala#L66
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/seancxmao/spark SPARK-13136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21113
----
commit 6aceb43c56641a38b97b5e090379ef5143f17dd0
Author: seancxmao <se...@...>
Date: 2018-04-20T07:12:09Z
fix comment issue
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21113
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21113
Merged to master, branch-2.3 and branch-2.2.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21113: [MINOR][DOCS] Fix comments of SQLExecution#withEx...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21113
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [SPARK-13136][SQL][FOLLOW-UP] Fix comment
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21113
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21113
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89753/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21113
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21113
**[Test build #4155 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4155/testReport)** for PR 21113 at commit [`6aceb43`](https://github.com/apache/spark/commit/6aceb43c56641a38b97b5e090379ef5143f17dd0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [SPARK-13136][SQL][FOLLOW-UP] Fix comment
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21113
Let's just name it to `[MINOR][DOCS] ... `. Mind finding more typo mistakes while we are here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21113
**[Test build #89730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89730/testReport)** for PR 21113 at commit [`6aceb43`](https://github.com/apache/spark/commit/6aceb43c56641a38b97b5e090379ef5143f17dd0).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21113
**[Test build #89730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89730/testReport)** for PR 21113 at commit [`6aceb43`](https://github.com/apache/spark/commit/6aceb43c56641a38b97b5e090379ef5143f17dd0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21113: [MINOR][DOCS] Fix comments of SQLExecution#withEx...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21113#discussion_r183582806
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -88,7 +88,7 @@ object SQLExecution {
/**
* Wrap an action with a known executionId. When running a different action in a different
* thread from the original one, this method can be used to connect the Spark jobs in this action
- * with the known executionId, e.g., `BroadcastHashJoin.broadcastFuture`.
+ * with the known executionId, e.g., `BroadcastExchange.relationFuture`.
--- End diff --
`BroadcastExchange` -> `BroadcastExchangeExec`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21113
**[Test build #89753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89753/testReport)** for PR 21113 at commit [`c8adec6`](https://github.com/apache/spark/commit/c8adec619f4337e29509a760e8ca84ddc3f851ec).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21113
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89730/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [SPARK-13136][SQL][FOLLOW-UP] Fix comment
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21113
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21113
**[Test build #89753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89753/testReport)** for PR 21113 at commit [`c8adec6`](https://github.com/apache/spark/commit/c8adec619f4337e29509a760e8ca84ddc3f851ec).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21113
**[Test build #4155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4155/testReport)** for PR 21113 at commit [`6aceb43`](https://github.com/apache/spark/commit/6aceb43c56641a38b97b5e090379ef5143f17dd0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21113: [MINOR][DOCS] Fix comments of SQLExecution#withExecution...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21113
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org