You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Lance Weber (JIRA)" <ji...@apache.org> on 2009/09/02 04:50:33 UTC
[jira] Created: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Add version number validation between Cassandra and Thrift
----------------------------------------------------------
Key: CASSANDRA-412
URL: https://issues.apache.org/jira/browse/CASSANDRA-412
Project: Cassandra
Issue Type: New Feature
Components: Core
Affects Versions: 0.4
Environment: all
Reporter: Lance Weber
Priority: Minor
Fix For: 0.5
Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756719#action_12756719 ]
Jonathan Ellis commented on CASSANDRA-412:
------------------------------------------
my mistake, it goes in new Constants.java
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756731#action_12756731 ]
Jonathan Ellis commented on CASSANDRA-412:
------------------------------------------
I don't want to promise that there is some function f such that if f(version2) > f(version1) then all version1 commands will work fine with version2. Given that, why would you need to do anything b/s a dumb string compare on the version?
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756759#action_12756759 ]
Michael Greene commented on CASSANDRA-412:
------------------------------------------
Totally right, I wasn't thinking it through.
+1
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-412:
-------------------------------------
Attachment: 412.patch
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756712#action_12756712 ]
Jonathan Ellis commented on CASSANDRA-412:
------------------------------------------
I added
const string VERSION = "0.5-dev-1"
as found at http://wiki.apache.org/thrift/Tutorial
but this wasn't actually put in any of the generated .java files. yay.
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756750#action_12756750 ]
Jonathan Ellis commented on CASSANDRA-412:
------------------------------------------
not only that, we promised minor releases would only contain bugfixes. so the thrift shouldn't change at all... unless it has to for a fix, such as adding a new Exception, in which case there's nothing you can do to avoid breakage.
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756725#action_12756725 ]
Michael Greene commented on CASSANDRA-412:
------------------------------------------
With versions defined like this, everyone needs to write a small parser to check whether they should be compatible or not. There are both periods, hyphens, numbers, and strings. Shouldn't it be possible to use a version that's more easily programmed against?
Otherwise, patch looks fine and builds the same Constants file over here.
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756744#action_12756744 ]
Michael Greene commented on CASSANDRA-412:
------------------------------------------
Didn't we already promise that minor releases would retain compatibility? i.e. that 0.5.1 would work with something programmed against 0.5?
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757145#action_12757145 ]
Hudson commented on CASSANDRA-412:
----------------------------------
Integrated in Cassandra #201 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/201/])
add thrift version string.
patch by jbellis; reviewed by Michael Greene for
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-412) Add version number validation
between Cassandra and Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-412.
--------------------------------------
Resolution: Fixed
Assignee: Jonathan Ellis
committed, with added comment in .thrift warning users to not assume that non-equal versions will have a subset/superset relationship
> Add version number validation between Cassandra and Thrift
> ----------------------------------------------------------
>
> Key: CASSANDRA-412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-412
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Lance Weber
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 412.patch
>
>
> Requesting a versioning mechanism in thrift so that client and/or server side incompatibilities would be caught explicitly.
> jbellis recommends: "we could define a THRIFT_VERSION constant in the .thrift file (i think)"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.