You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/16 10:44:59 UTC

svn commit: r1696120 - in /commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6: AnnotationAccessFlagTestCase.java AnnotationDefaultAttributeTestCase.java AnonymousClassTestCase.java CounterVisitorTestCase.java

Author: sebb
Date: Sun Aug 16 08:44:59 2015
New Revision: 1696120

URL: http://svn.apache.org/r1696120
Log:
Extract common test package base name and eliminate dependency on actual package name

Modified:
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationAccessFlagTestCase.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationDefaultAttributeTestCase.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnonymousClassTestCase.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/CounterVisitorTestCase.java

Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationAccessFlagTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationAccessFlagTestCase.java?rev=1696120&r1=1696119&r2=1696120&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationAccessFlagTestCase.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationAccessFlagTestCase.java Sun Aug 16 08:44:59 2015
@@ -29,11 +29,11 @@ public class AnnotationAccessFlagTestCas
      */
     public void testAnnotationClassSaysItIs() throws ClassNotFoundException
     {
-        JavaClass clazz = getTestClass("org.apache.commons.bcel6.data.SimpleAnnotation");
+        JavaClass clazz = getTestClass(PACKAGE_BASE_NAME+".data.SimpleAnnotation");
         assertTrue(
                 "Expected SimpleAnnotation class to say it was an annotation - but it didn't !",
                 clazz.isAnnotation());
-        clazz = getTestClass("org.apache.commons.bcel6.data.SimpleClass");
+        clazz = getTestClass(PACKAGE_BASE_NAME+".data.SimpleClass");
         assertTrue(
                 "Expected SimpleClass class to say it was not an annotation - but it didn't !",
                 !clazz.isAnnotation());

Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationDefaultAttributeTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationDefaultAttributeTestCase.java?rev=1696120&r1=1696119&r2=1696120&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationDefaultAttributeTestCase.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnnotationDefaultAttributeTestCase.java Sun Aug 16 08:44:59 2015
@@ -33,7 +33,7 @@ public class AnnotationDefaultAttributeT
      */
     public void testMethodAnnotations() throws ClassNotFoundException
     {
-        JavaClass clazz = getTestClass("org.apache.commons.bcel6.data.SimpleAnnotation");
+        JavaClass clazz = getTestClass(PACKAGE_BASE_NAME+".data.SimpleAnnotation");
         Method m = getMethod(clazz, "fruit");
         AnnotationDefault a = (AnnotationDefault) findAttribute(
                 "AnnotationDefault", m.getAttributes());

Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnonymousClassTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnonymousClassTestCase.java?rev=1696120&r1=1696119&r2=1696120&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnonymousClassTestCase.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/AnonymousClassTestCase.java Sun Aug 16 08:44:59 2015
@@ -24,7 +24,7 @@ public class AnonymousClassTestCase exte
 {
     public void testRegularClassIsNotAnonymous() throws ClassNotFoundException
     {
-        JavaClass clazz = getTestClass("org.apache.commons.bcel6.data.AnonymousClassTest");
+        JavaClass clazz = getTestClass(PACKAGE_BASE_NAME+".data.AnonymousClassTest");
         assertFalse("regular outer classes are not anonymous", clazz
                 .isAnonymous());
         assertFalse("regular outer classes are not nested", clazz.isNested());

Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/CounterVisitorTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/CounterVisitorTestCase.java?rev=1696120&r1=1696119&r2=1696120&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/CounterVisitorTestCase.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/CounterVisitorTestCase.java Sun Aug 16 08:44:59 2015
@@ -25,7 +25,7 @@ public class CounterVisitorTestCase exte
     @Override
     protected JavaClass getTestClass() throws ClassNotFoundException
     {
-        return getTestClass("org.apache.commons.bcel6.data.MarkedType");
+        return getTestClass(PACKAGE_BASE_NAME+".data.MarkedType");
     }
 
     public void testAnnotationsCount()