You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2023/02/13 18:16:00 UTC
[jira] [Commented] (SOLR-16488) Create a v2 equivalent for /admin/zookeeper v1 APIs
[ https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688063#comment-17688063 ]
Jason Gerlowski commented on SOLR-16488:
----------------------------------------
Hey [~joshgogz], I was reviewing your PR and noticed that Solr actually _does_ have a v2 API for this functionality: ZookeeperReadAPI (introduced by SOLR-13942). I missed this entirely when I was identifying v2 gaps, and filed this ticket.
Interestingly, the v2 APIs in ZookeeperReadAPI are totally unrelated to the v1 APIs in ZooKeeperInfoHandler and ZooKeeperStatusHandler, despite implementing nearly identical functionality. In fact, SOLR-13942 proposes deprecating ZooKeeperInfoHandler and ZooKeeperStatusHandler entirely.
That leaves our path forward on this ticket a little unclear. The immediate goal of this ticket, v2 parity in this specific area, is done! That said, the v2 endpoints I recently uncovered could use improved in a few ways. Particularly they don't quite fit the RESTful design of many other v2 endpoints, and they could use to be switched over to JAX-RS. I'd suggest we repurpose this ticket to cover the tweaks needed to make that happen.
I'm going to take a crack at a PR and will post again here summarizing the changes when ready.
> Create a v2 equivalent for /admin/zookeeper v1 APIs
> ---------------------------------------------------
>
> Key: SOLR-16488
> URL: https://issues.apache.org/jira/browse/SOLR-16488
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Affects Versions: 9.1, main (10.0)
> Reporter: Jason Gerlowski
> Priority: Major
> Labels: newdev
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The /admin/zookeeper APIs have no equivalent in the v2 paradigm. We should close this gap, ideally with APIs similar to those below:
> * Get all ZK "Files"
> ** Current v1 API: GET /solr/admin/zookeeper
> ** Proposed v2 API: GET /api/cluster/zookeeper/files
> ** Spreadsheet Ref: Tab 7, Line 25
> * Get Single ZK "File"
> ** Current v1 API: GET /solr/admin/zookeeper?detail=true&path=someZkPath
> ** Proposed v2 API: GET /api/cluster/zookeeper/files/someZkPath
> ** Spreadsheet Ref: Tab 7, Line 26
> * Get Zk Status/health
> ** Current v1 API: GET /solr/admin/zookeeper/status
> ** Proposed v2 API: GET /api/cluster/zookeeper/status
> ** Spreadsheet Ref: Tab 7, Line 27
> "Spreadsheet References" are to the Google Sheet available [here|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing], which includes additional information about each API, such as the hosting RequestHandler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org