You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/16 03:22:51 UTC
[GitHub] [maven-build-cache-extension] AlexanderAshitkin opened a new pull request, #28: Documentation updates - fixed references to config file after rename,…
AlexanderAshitkin opened a new pull request, #28:
URL: https://github.com/apache/maven-build-cache-extension/pull/28
Documentation updates - fixed references to config file after rename, added notes about subtree discovery aashitki A minute ago
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet merged pull request #28: Documentation updates
Posted by GitBox <gi...@apache.org>.
gnodet merged PR #28:
URL: https://github.com/apache/maven-build-cache-extension/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet commented on a diff in pull request #28: Documentation updates
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #28:
URL: https://github.com/apache/maven-build-cache-extension/pull/28#discussion_r996479967
##########
src/site/markdown/usage.md:
##########
@@ -24,11 +24,23 @@ Once extension is activated, cache will kick-in automatically on every lifecycle
Build could be invoked on any module in project and will try to discover cache by introspecting dependencies. In order
to identify which dependencies are part of cacheable project the cache engine needs to know:
-* full project root location which must be passed with `-Dmaven.multiModuleProjectDirectory`
-* Specify profiles which activate full graph in config:
+* Full project root location which must be passed with `-Dmaven.multiModuleProjectDirectory`
+* Profiles which activate full graph in project build. Underlying implementation logic is to introspect reactor
+ graph in `full` mode to discover which dependencies are part of the cacheable project. This information will be used
+ then any subtree is being build to identify dependencies as a part of the project:
Review Comment:
Not sure of the intended meaning of `will be used then`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #28: Documentation updates
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on code in PR #28:
URL: https://github.com/apache/maven-build-cache-extension/pull/28#discussion_r998792388
##########
src/site/markdown/usage.md:
##########
@@ -24,11 +24,23 @@ Once extension is activated, cache will kick-in automatically on every lifecycle
Build could be invoked on any module in project and will try to discover cache by introspecting dependencies. In order
to identify which dependencies are part of cacheable project the cache engine needs to know:
-* full project root location which must be passed with `-Dmaven.multiModuleProjectDirectory`
-* Specify profiles which activate full graph in config:
+* Full project root location which must be passed with `-Dmaven.multiModuleProjectDirectory`
+* Profiles which activate full graph in project build. Underlying implementation logic is to introspect reactor
+ graph in `full` mode to discover which dependencies are part of the cacheable project. This information will be used
+ then any subtree is being build to identify dependencies as a part of the project:
Review Comment:
Thank you! Slightly reworded, hope it is better now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org