You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/03/06 09:54:11 UTC
[Bug 59131] New: HTTP Request with JLabeledChoice editable for
Method isn't localized (L10N)
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
Bug ID: 59131
Summary: HTTP Request with JLabeledChoice editable for Method
isn't localized (L10N)
Product: JMeter
Version: Nightly (Please specify date)
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: HTTP
Assignee: issues@jmeter.apache.org
Reporter: milamber@apache.org
Created attachment 33630
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33630&action=edit
JLabeledChoice Not L10N
The new change of the Method field to have an editable field to add or delete a
method bring an issue in the localized versions of JMeter, the label of Add and
Delete button isn't localize, it's hard-coded in the
src/jorphan/org/apache/jorphan/gui/JLabeledChoice.java L149/L153.
This class is build inside the jorphan.jar package, which don't have any import
form JMeter API, so it's not possible to use the JMeter L10N mechanism.
Three options:
1/ Change the "Add" and "Del" label with " + " and " - " characters. Not
necessary to add some L10N mechanism, the plus and minus are recognized for Add
and Delete action in UI.
2/ Use icons for + and - (same than the collapse/expand toolbar button). Need
to add inside the jorphan.jar the icons and manage the HiDPI (some properties
to add or try to manage this automatically)
3/ Add some L10N messages.properties mechanism inside the jorphan.jar and use
this to translate the UI.
In attachment, some draft screenshot.
What is your prefer option ? 1 / 2 / 3 / other way ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] JLabeledChoice editable for Method isn't localized
(L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
--- Comment #7 from Sebb <se...@apache.org> ---
(In reply to Sebb from comment #4)
> I'm not sure why there needs to be a Delete function. Surely one just does
> not select it?
>
> Indeed, I'm not sure why there needs to be an Add button either.
>
> The way this works for the TestBean-based GUIs is to have an editable entry
> in the drop-down box. For example like the Language field in the
> JSR223Sampler.
>
> This can then either be a fixed value or even a variable reference.
>
> If this were done there would be no L10N issue.
>
> So my vote is for 'other way'.
I was confused by the title; it's a generic L10N issue, not just for HTTP GUI,
so it still may need addressing at some point.
Another solution would be to move the class out of Jorphan so the property
mechanisms are available.
I think we need to see if there are other classes that have the same issue.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] HTTP Request with JLabeledChoice editable for Method
isn't localized (L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
--- Comment #5 from Sebb <se...@apache.org> ---
Solved for HTTPRequest by dropping the Buttons
URL: http://svn.apache.org/viewvc?rev=1734185&view=rev
Log:
HTTP Request : Make Method field editable so that additional methods (Webdav)
can be added easily
Don't display Add/Del buttons
Bugzilla Id: 59083
Modified:
jmeter/trunk/src/jorphan/org/apache/jorphan/gui/JLabeledChoice.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/config/gui/UrlConfigGui.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] HTTP Request with JLabeledChoice editable for Method
isn't localized (L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
--- Comment #2 from Milamber <mi...@apache.org> ---
Created attachment 33632
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33632&action=edit
Plus or Minus are icons
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] HTTP Request with JLabeledChoice editable for Method
isn't localized (L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
--- Comment #4 from Sebb <se...@apache.org> ---
I'm not sure why there needs to be a Delete function. Surely one just does not
select it?
Indeed, I'm not sure why there needs to be an Add button either.
The way this works for the TestBean-based GUIs is to have an editable entry in
the drop-down box. For example like the Language field in the JSR223Sampler.
This can then either be a fixed value or even a variable reference.
If this were done there would be no L10N issue.
So my vote is for 'other way'.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] JLabeledChoice editable for Method isn't localized
(L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Linux |All
Severity|normal |enhancement
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] JLabeledChoice isn't localized (L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|JLabeledChoice editable for |JLabeledChoice isn't
|Method isn't localized |localized (L10N)
|(L10N) |
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] HTTP Request with JLabeledChoice editable for Method
isn't localized (L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
--- Comment #1 from Milamber <mi...@apache.org> ---
Created attachment 33631
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33631&action=edit
Plus or Minus are characters
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] JLabeledChoice editable for Method isn't localized
(L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|HTTP |Main
Summary|HTTP Request with |JLabeledChoice editable for
|JLabeledChoice editable for |Method isn't localized
|Method isn't localized |(L10N)
|(L10N) |
--- Comment #6 from Sebb <se...@apache.org> ---
Renamed; it's not HTTP specific
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] HTTP Request with JLabeledChoice editable for Method
isn't localized (L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.mouawad@ubik-ingenierie.c
| |om
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Milamber from comment #0)
> Created attachment 33630 [details]
> JLabeledChoice Not L10N
>
> The new change of the Method field to have an editable field to add or
> delete a method bring an issue in the localized versions of JMeter, the
> label of Add and Delete button isn't localize, it's hard-coded in the
> src/jorphan/org/apache/jorphan/gui/JLabeledChoice.java L149/L153.
>
> This class is build inside the jorphan.jar package, which don't have any
> import form JMeter API, so it's not possible to use the JMeter L10N
> mechanism.
>
> Three options:
>
> 1/ Change the "Add" and "Del" label with " + " and " - " characters. Not
> necessary to add some L10N mechanism, the plus and minus are recognized for
> Add and Delete action in UI.
>
+1 for me
> 2/ Use icons for + and - (same than the collapse/expand toolbar button).
> Need to add inside the jorphan.jar the icons and manage the HiDPI (some
> properties to add or try to manage this automatically)
>
> 3/ Add some L10N messages.properties mechanism inside the jorphan.jar and
> use this to translate the UI.
>
> In attachment, some draft screenshot.
>
> What is your prefer option ? 1 / 2 / 3 / other way ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] JLabeledChoice editable for Method isn't localized
(L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
Bug 59131 depends on bug 59083, which changed state.
Bug 59083 Summary: HTTP Request : Make Method field editable so that additional methods (Webdav) can be added easily
https://bz.apache.org/bugzilla/show_bug.cgi?id=59083
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59131] HTTP Request with JLabeledChoice editable for Method
isn't localized (L10N)
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59131
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |59083
--
You are receiving this mail because:
You are the assignee for the bug.