Re: svn commit: r386792 - /httpd/httpd/trunk/acinclude.m4

[Joe Orton <jo...@redhat.com>]

On Sat, Mar 18, 2006 at 02:26:21AM -0000, Justin Erenkrantz wrote:
> Author: jerenkrantz
> Date: Fri Mar 17 18:26:19 2006
> New Revision: 386792
> 
> URL: http://svn.apache.org/viewcvs?rev=386792&view=rev
> Log:
> * acinclude.m4: When enabling a static library, ensure that the module's
>   dependent libraries are passed to the httpd link line.  Some supported
>   versions of GNU libtool as well as APR's jlibtool do not bubble-up static
>   library dependencies.

What supported versions of GNU libtool do this, what platform?  Can you 
give a repro case so I can report this upstream?  I've seen no reports 
of such problems with 2.2.x.

> 
> Modified:
>     httpd/httpd/trunk/acinclude.m4
> 
> Modified: httpd/httpd/trunk/acinclude.m4
> URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/acinclude.m4?rev=386792&r1=386791&r2=386792&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/acinclude.m4 (original)
> +++ httpd/httpd/trunk/acinclude.m4 Fri Mar 17 18:26:19 2006
> @@ -183,6 +183,9 @@
>  $libname: $objects
>  	\$(MOD_LINK) $objects $5
>  EOF
> +      if test ! -z "$5"; then
> +        APR_ADDTO(AP_LIBS, [$5])
> +      fi
>      else
>        apache_need_shared=yes
>        libname="mod_$1.la"
> 

Re: svn commit: r386792 - /httpd/httpd/trunk/acinclude.m4

[Justin Erenkrantz <ju...@erenkrantz.com>]

On 3/21/06, Joe Orton <jo...@redhat.com> wrote:
> What supported versions of GNU libtool do this, what platform?

1.3 and 1.4 variants that are long unsupported or were tweaked
incorrectly by the packager.  The stock 1.5 series gets it right.

> Can you
> give a repro case so I can report this upstream?  I've seen no reports
> of such problems with 2.2.x.

It also happens with APR's jlibtool - which was the specific case I'm
interested in.

*shrug*  -- justin