You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/28 20:04:13 UTC
[jira] [Commented] (NIFI-1806) Add UTF-8 for file enconding in unit
tests during maven build
[ https://issues.apache.org/jira/browse/NIFI-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262636#comment-15262636 ]
ASF GitHub Bot commented on NIFI-1806:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/390
NIFI-1806 Set file encoding to UTF-8 when running unit tests
Full build is OK.
Tested with Windows 10 / Java 8.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-1806
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit bdb5d04f29f2529dc653815510b38b255841f155
Author: Pierre Villard <pi...@gmail.com>
Date: 2016-04-28T18:02:08Z
NIFI-1806 Set file encoding to UTF-8 when running unit tests
----
> Add UTF-8 for file enconding in unit tests during maven build
> -------------------------------------------------------------
>
> Key: NIFI-1806
> URL: https://issues.apache.org/jira/browse/NIFI-1806
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 0.6.1
> Reporter: Pierre Villard
> Priority: Minor
> Labels: build, maven, test
>
> Following discussion here :
> https://github.com/apache/nifi/pull/366#discussion_r60829511
> For some tests, it seems to be necessary to add the following in pom file:
> {code:title=pom.xml|borderStyle=solid}
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <configuration>
> <argLine>-Dfile.encoding=UTF-8</argLine>
> </configuration>
> </plugin>
> </plugins>
> </build>
> {code}
> Ideally this could be added in the parent pom but it must be ensured that this would not affect other components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)