[GitHub] [ozone] JacksonYao287 commented on a diff in pull request #3352: HDDS-6589. Add a new replication manager and change the existing one to legacy

[GitBox <gi...@apache.org>]

JacksonYao287 commented on code in PR #3352:
URL: https://github.com/apache/ozone/pull/3352#discussion_r862334706


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/LegacyReplicationManager.java:
##########
@@ -781,14 +645,10 @@ public CompletableFuture<MoveResult> move(ContainerID cid,
    * @param cid Container to move
    * @param mp MoveDataNodePair which contains source and target datanodes
    */
-  public CompletableFuture<MoveResult> move(ContainerID cid,
+  private CompletableFuture<MoveResult> move(ContainerID cid,
       MoveDataNodePair mp)
       throws ContainerNotFoundException, NodeNotFoundException {
     CompletableFuture<MoveResult> ret = new CompletableFuture<>();
-    if (!isRunning()) {

Review Comment:
   since the legacy RM does not have any scheduling logic, it is just a container processor now and does not know whether the new RM is running. the check is needed, and has been moved to the new RM , please see 
   [the check in new RM](https://github.com/apache/ozone/pull/3352/files/dcb2ce3c53bc01ed30aab1b27e494cddfda5a44a#diff-8be983672d581b5fdec0b1a7ce4fe4f0ee29a25684f2af3680604d51d3ebbb52R412)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org