[jira] [Commented] (KARAF-4280) Feature config overwrites existing values

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220855#comment-15220855 ] 

ASF subversion and git services commented on KARAF-4280:
--------------------------------------------------------

Commit 522d61b7fda4da44b5bade9ef917826f489c7757 in karaf's branch refs/heads/karaf-4.0.x from [~jbonofre]
[ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=522d61b ]

KARAF-4280 - In case of update, use the actual property for the storage


> Feature config overwrites existing values
> -----------------------------------------
>
>                 Key: KARAF-4280
>                 URL: https://issues.apache.org/jira/browse/KARAF-4280
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config, karaf-feature
>    Affects Versions: 4.0.4
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 4.1.0, 4.0.5
>
>
> The feature configuration (KARAF-3100) seems to have conflicting rules when appending new feature configuration values to an existing configuration. If the feature file contains a new config key, then all values are taken from the feature config keys. But the code before it puts only new values to component configuration.
> So the FeatureConfigInstaller flow is:
> 1.       installFeatureConfigs uses existing values and only appends new ones (lines 114-118)
> 2.       updateStorage overwrites all values from the ones in feature configuration (lines 266-275)
> I think this is a bug: it seems that the intention is to keep the existing configuration as is and only append new values. Which makes more sense to me.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)