You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/02 11:54:21 UTC
[GitHub] [iotdb] neuyilan commented on a change in pull request #2725: [IOTDB-1164]Optimize the executeBatch interface in JDBC
neuyilan commented on a change in pull request #2725:
URL: https://github.com/apache/iotdb/pull/2725#discussion_r585486235
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -431,61 +431,85 @@ private String getMetadataInString() {
return IoTDB.metaManager.getAllTimeseriesPath(path);
}
+ private boolean executeInsertRowsPlan(InsertRowsPlan insertRowsPlan, List<TSStatus> result) {
+ long t2 = System.currentTimeMillis();
Review comment:
```suggestion
long t1 = System.currentTimeMillis();
```
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -431,61 +431,85 @@ private String getMetadataInString() {
return IoTDB.metaManager.getAllTimeseriesPath(path);
}
+ private boolean executeInsertRowsPlan(InsertRowsPlan insertRowsPlan, List<TSStatus> result) {
+ long t2 = System.currentTimeMillis();
+ TSStatus tsStatus = executeNonQueryPlan(insertRowsPlan);
+ Measurement.INSTANCE.addOperationLatency(Operation.EXECUTE_ROWS_PLAN_IN_BATCH, t2);
Review comment:
```suggestion
Measurement.INSTANCE.addOperationLatency(Operation.EXECUTE_ROWS_PLAN_IN_BATCH, t1);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org