You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/03/27 08:33:47 UTC
Review Request: Multiplexing channel selector config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4514/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Multiplexing channel selector config
This addresses bug FLUME-1064.
https://issues.apache.org/jira/browse/FLUME-1064
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 83928b7
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
Diff: https://reviews.apache.org/r/4514/diff
Testing
-------
Thanks,
Hari
Re: Review Request: Channel selector config
Posted by Juhani Connolly <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4514/#review7724
-----------------------------------------------------------
Looks good to me.
It doesn't seem to patch correctly against the trunk, so if you could rebase it, that would help.
While not relevant to this issue, the configuration for this should really be documented, we can't expect end users to trawl the code to figure it out
If you can fix these niggles when you rebase it, shoud be good to go
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java
<https://reviews.apache.org/r/4514/#comment17020>
Changing the name immutableMap to something more descriptive would help legibility
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java
<https://reviews.apache.org/r/4514/#comment17018>
weird indentation(this should be ending the function... looks like refactoring tools used the wrong closing bracket
- Juhani
On 2012-04-24 04:22:25, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4514/
> -----------------------------------------------------------
>
> (Updated 2012-04-24 04:22:25)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Channel selector config
>
>
> This addresses bug FLUME-1064.
> https://issues.apache.org/jira/browse/FLUME-1064
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 83928b7
> flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
>
> Diff: https://reviews.apache.org/r/4514/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: Channel selector config
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4514/
-----------------------------------------------------------
(Updated 2012-04-24 04:22:25.831269)
Review request for Flume.
Summary (updated)
-------
Channel selector config
This addresses bug FLUME-1064.
https://issues.apache.org/jira/browse/FLUME-1064
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 83928b7
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
Diff: https://reviews.apache.org/r/4514/diff
Testing
-------
Thanks,
Hari
Re: Review Request: Multiplexing channel selector config
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4514/
-----------------------------------------------------------
(Updated 2012-04-24 03:42:26.744186)
Review request for Flume.
Changes
-------
Update with new changes. Note that this *has to be* checked in before any source specific configuration stub because of a dependency in the SourceConfiguration class(which I admit, I had missed).
Summary
-------
Multiplexing channel selector config
This addresses bug FLUME-1064.
https://issues.apache.org/jira/browse/FLUME-1064
Diffs (updated)
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 83928b7
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
Diff: https://reviews.apache.org/r/4514/diff
Testing
-------
Thanks,
Hari