[GitHub] [spark] brkyvz commented on a diff in pull request #38113: [SPARK-40667][SQL] Refactor File Data Source Options

[GitBox <gi...@apache.org>]

brkyvz commented on code in PR #38113:
URL: https://github.com/apache/spark/pull/38113#discussion_r989293268


##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala:
##########
@@ -41,6 +41,12 @@ private[sql] class AvroOptions(
     this(CaseInsensitiveMap(parameters), conf)
   }
 
+  private def getString(paramName: AvroOptions.Value): Option[String] = {
+    parameters.get(paramName.toString)
+  }

Review Comment:
   Seems like this leads to a much higher line of changes, don't think it adds much value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org