You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 15:26:06 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #1563: Split out list array
tustvold opened a new pull request, #1563:
URL: https://github.com/apache/arrow-rs/pull/1563
**Draft as builds on #1562 **
# Which issue does this PR close?
Part of #1483
# Rationale for this change
See ticket
# What changes are included in this PR?
See ticket
# Are there any user-facing changes?
The only changes are to experimental modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1563: Split out ListArrayReader into separate module (#1483)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1563:
URL: https://github.com/apache/arrow-rs/pull/1563#issuecomment-1098220371
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1563](https://codecov.io/gh/apache/arrow-rs/pull/1563?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ece461f) into [master](https://codecov.io/gh/apache/arrow-rs/commit/228ee36eeec26867a951c6a381e3e129765e21cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (228ee36) will **decrease** coverage by `0.00%`.
> The diff coverage is `78.87%`.
> :exclamation: Current head ece461f differs from pull request most recent head e58f3da. Consider uploading reports for the commit e58f3da to get more accurate results
```diff
@@ Coverage Diff @@
## master #1563 +/- ##
==========================================
- Coverage 82.84% 82.84% -0.01%
==========================================
Files 190 192 +2
Lines 54985 54988 +3
==========================================
+ Hits 45551 45553 +2
- Misses 9434 9435 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/arrow/array\_reader/test\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/1563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyL3Rlc3RfdXRpbC5ycw==) | `83.33% <55.55%> (-16.67%)` | :arrow_down: |
| [parquet/src/arrow/array\_reader/map\_array.rs](https://codecov.io/gh/apache/arrow-rs/pull/1563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyL21hcF9hcnJheS5ycw==) | `65.57% <65.57%> (ø)` | |
| [parquet/src/arrow/array\_reader/list\_array.rs](https://codecov.io/gh/apache/arrow-rs/pull/1563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyL2xpc3RfYXJyYXkucnM=) | `87.96% <87.96%> (ø)` | |
| [parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyLnJz) | `89.96% <100.00%> (+2.88%)` | :arrow_up: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.37% <0.00%> (-0.19%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.80% <0.00%> (+0.39%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1563?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1563?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [228ee36...e58f3da](https://codecov.io/gh/apache/arrow-rs/pull/1563?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1563: Split out ListArrayReader into separate module (#1483)
Posted by GitBox <gi...@apache.org>.
alamb merged PR #1563:
URL: https://github.com/apache/arrow-rs/pull/1563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1563: Split out ListArrayReader into separate module (#1483)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1563:
URL: https://github.com/apache/arrow-rs/pull/1563#discussion_r851261218
##########
parquet/src/arrow/array_reader.rs:
##########
@@ -1814,180 +1580,4 @@ mod tests {
struct_array_reader.get_rep_levels()
);
}
-
Review Comment:
Moved to list_array module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1563: Split out ListArrayReader into separate module (#1483)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1563:
URL: https://github.com/apache/arrow-rs/pull/1563#discussion_r851261108
##########
parquet/src/arrow/array_reader.rs:
##########
@@ -649,157 +649,6 @@ where
}
}
-/// Implementation of list array reader.
Review Comment:
Moved to list_array module
##########
parquet/src/arrow/array_reader.rs:
##########
@@ -1690,81 +1531,6 @@ mod tests {
);
}
- /// Array reader for test.
Review Comment:
Moved to test_utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org