You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Igor V. Stolyarov (JIRA)" <ji...@apache.org> on 2008/02/12 08:58:07 UTC

[jira] Created: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

[classlib][awt] GifDecoder not always passes ColorModel through setPixels method
--------------------------------------------------------------------------------

                 Key: HARMONY-5491
                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Igor V. Stolyarov
         Attachments: H-5491.patch

GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Igor V. Stolyarov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor V. Stolyarov updated HARMONY-5491:
---------------------------------------

    Attachment: GifDecoderTest.patch

Attached regression test.

> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>            Assignee: Tim Ellison
>         Attachments: GifDecoderTest.patch, H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Igor V. Stolyarov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569854#action_12569854 ] 

Igor V. Stolyarov commented on HARMONY-5491:
--------------------------------------------

Regression test needs to be added into SVN.

Thanks,
Igor

> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>            Assignee: Tim Ellison
>         Attachments: GifDecoderTest.patch, H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Igor V. Stolyarov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568469#action_12568469 ] 

Igor V. Stolyarov commented on HARMONY-5491:
--------------------------------------------

Works for me. Thank you Tim.
I'll try to create regression test ASAP.

Thanks,
Igor

> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>            Assignee: Tim Ellison
>         Attachments: H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568022#action_12568022 ] 

Tim Ellison commented on HARMONY-5491:
--------------------------------------

Thanks Igor.

Patch applied to AWT module at repo revision r620732.

I realize that the effect can be seen using the ImageMap demo applet, but do you have any suggestions for an automated regression test for this problem?  I wasn't clear to me how we can detect this case easily in a test case.


> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>            Assignee: Tim Ellison
>         Attachments: H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-5491.
----------------------------------

    Resolution: Fixed

Thanks Igor.

Regression test committed at repo revision r632300.

Please check this issue is now fully resolved.


> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>            Assignee: Tim Ellison
>         Attachments: GifDecoderTest.patch, H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Igor V. Stolyarov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor V. Stolyarov updated HARMONY-5491:
---------------------------------------

    Attachment: H-5491.patch

Fix attached

> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>         Attachments: H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison reassigned HARMONY-5491:
------------------------------------

    Assignee: Tim Ellison

> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>            Assignee: Tim Ellison
>         Attachments: H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5491) [classlib][awt] GifDecoder not always passes ColorModel through setPixels method

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison closed HARMONY-5491.
--------------------------------


No response, assuming the fix is ok.

> [classlib][awt] GifDecoder not always passes ColorModel through setPixels method
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-5491
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5491
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Igor V. Stolyarov
>            Assignee: Tim Ellison
>         Attachments: GifDecoderTest.patch, H-5491.patch
>
>
> GifDecoder not always passes ColorModel through setPixels method. This bug possible to reproduce on ImageMap demo applet, in that demo applet don't draw 3D buttons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.