You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2018/08/08 15:34:43 UTC
[GitHub] activemq-artemis pull request #2227: ARTEMIS-1482 Add back check for SimpleS...
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2227
ARTEMIS-1482 Add back check for SimpleString
The original fix was removed during a refactor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1482-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2227
----
commit 7520a5198a5f37a3afdbdf28fbb0625d424021a2
Author: Martyn Taylor <mt...@...>
Date: 2018-08-08T15:33:11Z
ARTEMIS-1482 Add back check for SimpleString
----
---
[GitHub] activemq-artemis issue #2227: ARTEMIS-1482 Add back check for SimpleString
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2227
My point was more ensuring in future its not regressed again.
---
[GitHub] activemq-artemis pull request #2227: ARTEMIS-1482 Add back check for SimpleS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2227
---
[GitHub] activemq-artemis issue #2227: ARTEMIS-1482 Add back check for SimpleString
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2227
@mtaylor see https://github.com/apache/activemq-artemis/pull/2232 please.
---
[GitHub] activemq-artemis issue #2227: ARTEMIS-1482 Add back check for SimpleString
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2227
@michaelandrepearce You are right indeed, but the change of @mtaylor is quite smart here: he is avoiding the allocation of byte[] at all, like in the original code :100:
---
[GitHub] activemq-artemis issue #2227: ARTEMIS-1482 Add back check for SimpleString
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2227
@michaelandrepearce I agree, if you can come up with an appropriate test it would be beneficial. The reason the test still passed was due to the IOOB exception being moved to a different position in the stack. So, it was thrown but only after the byte array memory was allocated.
---
[GitHub] activemq-artemis issue #2227: ARTEMIS-1482 Add back check for SimpleString
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2227
The test that was added in the original PR testOutOfBoundsThrownOnMalformedString seems to still pass on master, as such should this test be updated?
---