[GitHub] [flink] davidradl commented on a diff in pull request #23441: [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value

["davidradl (via GitHub)" <gi...@apache.org>]

davidradl commented on code in PR #23441:
URL: https://github.com/apache/flink/pull/23441#discussion_r1337464779


##########
flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java:
##########
@@ -60,8 +60,11 @@ public interface AppendingState<IN, OUT> extends State {
      *
      * <p>If null is passed in, the state value will remain unchanged.
      *
+     * <p>Except for list state, where null value is not allowed to be passed in.

Review Comment:
   I think when referring to list state you mean the ListState interface. I do not think that a parent interface should document special behaviour for a child interface. This breaks to the solid principle Liskov Substitution Principle and is not good practice.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org