[jira] [Commented] (AXIS2C-1649) please check your log and buffer - In log.c

["Alex Mantaut (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2C-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823744#comment-13823744 ] 

Alex Mantaut commented on AXIS2C-1649:
--------------------------------------

Hi Jean-Marc,

Looking at the code it seems that checking if format is not NULL makes sense. Format is the message and nothing should be logged if format is not set, also if a NULL format is passed it might segfault... 
I looked into the calls to axutil_log_impl_log_debug() and didn't found any call without a format... The thing that isn't always used are the variable arguments following... Can you show in which case it produces an error for you?

> please check your log and buffer - In log.c
> -------------------------------------------
>
>                 Key: AXIS2C-1649
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1649
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 1.7.0
>         Environment: AIX 6.1
>            Reporter: Jean-Marc Lamond
>            Priority: Minor
>         Attachments: log.c.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Can someone fix either util/src/log.c or all the reference to : axutil_log_impl_log_debug.  const axis2_char_t *format is most of the time not passed to the function and produce the erreur message.
> replace : if(log && log->ops && log->ops->write && format && log->enabled)
> with : if(log && log->ops && log->ops->write && log->enabled)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org