You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/16 22:03:20 UTC
[GitHub] [camel-k] tobiasoort opened a new pull request, #3820: Multi-architecture support #1238
tobiasoort opened a new pull request, #3820:
URL: https://github.com/apache/camel-k/pull/3820
#1238
- pushes container basis to quarkus v22.0.0.2
- implements multi-arch (arm64 and amd64 only since thats whats provided upstream @ quarkus)
- no cleanup of old 'arch' build yet, since I don't know what's dependent upon it.
This PR may be imperfect as I don't yet know how to run a test suite here and am hoping PRs have automated QC actions.
**Release Note**
```release-note
- pushed quarkus version to v22.0.0.2
- implemented multi-arch for amd64/arm64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort commented on pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
tobiasoort commented on PR #3820:
URL: https://github.com/apache/camel-k/pull/3820#issuecomment-1318550135
I'm currently not able to test this in my local branch due to a dependency on kind-registry which cannot be resolved. I'm pretty sure thats environment-specific so please start the pipelines here again so we can see how it works here. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort commented on pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
tobiasoort commented on PR #3820:
URL: https://github.com/apache/camel-k/pull/3820#issuecomment-1318302375
So I just 'manually' added qemu support. This isn't the best way! The cleanest way is through github actions, as described here: https://github.com/marketplace/actions/docker-setup-buildx
It seems though that the build architecture/setup for this project is a bit 'manual' and I don't want to pull all that refactoring into this (intented to be) simple, small fixup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3820:
URL: https://github.com/apache/camel-k/pull/3820#issuecomment-1319596338
@tobiasoort Can you squash the commits into single one? It's too many for the simple fix.
@phantomjinx What do you think about the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3820:
URL: https://github.com/apache/camel-k/pull/3820#issuecomment-1319719032
We can "squash and merge" instead of "rebase and merge". I think however the parameter setting for the platform is a must before going.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort closed pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
tobiasoort closed pull request #3820: Multi-architecture support #1238
URL: https://github.com/apache/camel-k/pull/3820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort commented on pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
tobiasoort commented on PR #3820:
URL: https://github.com/apache/camel-k/pull/3820#issuecomment-1326778298
I'll work on this PR in my fork and create a new one because this mess is only causing useless notifications for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3820:
URL: https://github.com/apache/camel-k/pull/3820#discussion_r1024879790
##########
script/Makefile:
##########
@@ -408,9 +408,11 @@ images: build kamel-overlay maven-overlay bundle-kamelets
ifneq (,$(findstring SNAPSHOT,$(RUNTIME_VERSION)))
./script/package_maven_artifacts.sh -s "$(STAGING_RUNTIME_REPO)" -d "$(CAMEL_K_RUNTIME_DIR)" $(RUNTIME_VERSION)
endif
- @echo "####### Building Camel K operator container image..."
+ @echo "####### Building Camel K operator container image for multi architectures..."
mkdir -p build/_maven_output
- docker build -t $(CUSTOM_IMAGE):$(CUSTOM_VERSION) -f build/Dockerfile .
+ docker buildx rm --all-inactive --force
+ docker buildx create --name builder --use
+ docker buildx build --platform=linux/amd64,linux/arm64 -t $(CUSTOM_IMAGE):$(CUSTOM_VERSION) -f build/Dockerfile .
Review Comment:
Probably we should have a parameter for the platform so that is customizable by the end used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tobiasoort commented on pull request #3820: Multi-architecture support #1238
Posted by GitBox <gi...@apache.org>.
tobiasoort commented on PR #3820:
URL: https://github.com/apache/camel-k/pull/3820#issuecomment-1320533154
Do we want the built arch(s) in the `VERSIONFILE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org