You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/27 12:45:21 UTC
[jira] [Commented] (FLINK-4695) Separate configuration parsing from MetricRegistry

    [ https://issues.apache.org/jira/browse/FLINK-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526004#comment-15526004 ] 

ASF GitHub Bot commented on FLINK-4695:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2555

    [FLINK-4695] Introduce MetricRegistryConfiguration to encapsulate MetricRegistry parameters

    In order to decouple the MetricRegistry object instantiation from the global configuration
    the MetricRegistryConfiguration class has been introduced. This class encapsulates all
    required information to create a MetricRegistry object. Furthermore, it encapsulates the
    configuration parsing logic by offering a static method fromConfiguration, which constructs
    a MetricRegistryConfiguration object from a Configuration.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink metricRegistryConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2555
    
----
commit 8e722cfa9b9301e4cb49ccc41a334d684ff2eb1f
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-09-26T14:49:23Z

    [FLINK-4695] Introduce MetricRegistryConfiguration to encapsulate MetricRegistry parameters
    
    In order to decouple the MetricRegistry object instantiation from the global configuration
    the MetricRegistryConfiguration class has been introduced. This class encapsulates all
    required information to create a MetricRegistry object. Furthermore, it encapsulates the
    configuration parsing logic by offering a static method fromConfiguration, which constructs
    a MetricRegistryConfiguration object from a Configuration.

----


> Separate configuration parsing from MetricRegistry
> --------------------------------------------------
>
>                 Key: FLINK-4695
>                 URL: https://issues.apache.org/jira/browse/FLINK-4695
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> In order to decouple the {{MetricRegistry}} object instantiation from the global configuration, we could introduce a {{MetricRegistryConfiguration}} object which encapsulates all necessary information for the {{MetricRegistry}}. The {{MetricRegistryConfiguration}} could have a static method to be generated from a {{Configuration}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)