[GitHub] eladkal commented on a change in pull request #4566: [AIRFLOW-3566] - Adding timeout and login_timeout to MsSqlHook

[GitBox <gi...@apache.org>]

eladkal commented on a change in pull request #4566: [AIRFLOW-3566] - Adding timeout and login_timeout to MsSqlHook
URL: https://github.com/apache/airflow/pull/4566#discussion_r251227431
 
 

 ##########
 File path: airflow/hooks/mssql_hook.py
 ##########
 @@ -45,7 +47,9 @@ def get_conn(self):
             user=conn.login,
             password=conn.password,
             database=self.schema or conn.schema,
-            port=conn.port)
+            port=conn.port,
+            timeout=self.timeout,
+            login_timeout=self.login_timeout or conn.login_timeout)
 
 Review comment:
   @ashb You are correct.
   How would you feel about getting it from the extra field?
   `login_timeout=self.login_timeout or conn.extra_dejson.get('login_timeout')`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services