You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/19 23:46:20 UTC
[I] Remove spec-only PresetService members [texera]
aglinxinyuan opened a new issue, #8611:
URL: https://github.com/apache/texera/issues/8611
### Task Summary
Three `PresetService` members have no production caller: `updateOrCreatePreset`, `isValidNewOperatorPreset`, and the exported `PresetDictionary` type.
### History
| | |
| --- | --- |
| **Introduced by** | #1164 (2022-01-13) — "Add PresetService (User Presets Step 3)", which built out the preset API surface |
| **Usage removed by** | **never wired up** — no production file has ever called `updateOrCreatePreset` or `isValidNewOperatorPreset`, and `PresetDictionary` has zero references worktree-wide. Only the service's own spec exercises them |
The wired-up half of the service stays: `savePresets`, `getPresets`, `applyPreset`, `isValidOperatorPreset`, `isValidPreset` and the Ajv type guards all have live consumers, and `common/formly/preset-wrapper/**` calls none of the removed three.
Pure deletion, no behaviour change: −175 lines.
### Task Type
- [x] Refactor / Cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove spec-only PresetService members [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #8611: Remove spec-only PresetService members
URL: https://github.com/apache/texera/issues/8611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org