You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2023/11/15 08:03:37 UTC
[PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
zhiqiang-hhhh opened a new pull request, #27035:
URL: https://github.com/apache/doris/pull/27035
Effect: Client will see error message like below when BE meeting plan logical error.
```txt
RROR 1105 (HY000): errCode = 2, detailMessage = ([xxx]())[CANCELLED]Logical error during processing VNewOlapScanNode(dr_case_tag), output of projections 2 mismatches with exec node output 3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1811975694
run buidlall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1812111184
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1811982928
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1812111264
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1811987896
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1812103605
TeamCity be ut coverage result:
Function Coverage: 36.79% (8417/22879)
Line Coverage: 29.27% (68382/233615)
Region Coverage: 27.87% (35344/126820)
Branch Coverage: 24.64% (18062/73296)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ffed1d6784f1c784efb27eca7c23432b22273440_ffed1d6784f1c784efb27eca7c23432b22273440/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #27035:
URL: https://github.com/apache/doris/pull/27035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1812063209
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit ffed1d6784f1c784efb27eca7c23432b22273440, data reload: true
run tpch-sf100 query with default conf and session variables
q1 5472 5053 5084 5053
q2 499 126 117 117
q3 2104 1939 1901 1901
q4 1784 1277 1265 1265
q5 4114 3947 3961 3947
q6 247 125 130 125
q7 1376 878 874 874
q8 3064 2776 2762 2762
q9 9942 9672 9626 9626
q10 9901 3531 3525 3525
q11 405 257 244 244
q12 452 299 299 299
q13 5753 4033 4019 4019
q14 342 332 346 332
q15 618 579 575 575
q16 736 630 576 576
q17 1137 976 921 921
q18 7908 7316 7545 7316
q19 1730 1678 1679 1678
q20 570 293 293 293
q21 4445 4026 3997 3997
q22 513 406 404 404
Total cold run time: 63112 ms
Total hot run time: 49849 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5005 5104 5036 5036
q2 318 218 224 218
q3 4096 3968 3918 3918
q4 2780 2735 2725 2725
q5 9638 9622 9602 9602
q6 241 116 123 116
q7 2683 2288 2313 2288
q8 4851 4880 4888 4880
q9 13279 13395 13152 13152
q10 4067 4174 4133 4133
q11 799 655 642 642
q12 981 835 798 798
q13 4282 3574 3573 3573
q14 382 338 335 335
q15 589 529 531 529
q16 740 690 675 675
q17 3921 3874 3919 3874
q18 9452 8990 9016 8990
q19 1824 1784 1795 1784
q20 2386 2062 2043 2043
q21 8763 8533 8513 8513
q22 917 871 843 843
Total cold run time: 81994 ms
Total hot run time: 78667 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](pipeline) Return InternalError to FE instead of doing a useless DCHECK in ExecNode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27035:
URL: https://github.com/apache/doris/pull/27035#issuecomment-1812030191
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.5 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17096338249 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org