You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/01/19 07:44:22 UTC
[PR] [SPARK-46770][K8S][TESTS] Remove legacy `docker-for-desktop` logic [spark]
dongjoon-hyun opened a new pull request, #44796:
URL: https://github.com/apache/spark/pull/44796
### What changes were proposed in this pull request?
This PR aims to remove legacy `docker-for-desktop` logic in favor of `docker-desktop`.
### Why are the changes needed?
Docker Desktop switched the underlying node name and context to `docker-desktop` in 2020. Apache Spark adopted the change since 3.2.2 and now we can delete it.
- https://github.com/docker/for-win/issues/5089#issuecomment-582752325
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46770][K8S][TESTS] Remove legacy `docker-for-desktop` logic [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44796:
URL: https://github.com/apache/spark/pull/44796#issuecomment-1899959573
Thank you! I'll merge this because I verified this manually~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46770][K8S][TESTS] Remove legacy `docker-for-desktop` logic [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44796:
URL: https://github.com/apache/spark/pull/44796#issuecomment-1899931151
Could you review this K8s test PR, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46770][K8S][TESTS] Remove legacy `docker-for-desktop` logic [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44796: [SPARK-46770][K8S][TESTS] Remove legacy `docker-for-desktop` logic
URL: https://github.com/apache/spark/pull/44796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org