You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/18 11:10:17 UTC

[GitHub] [incubator-nuttx] juniskane commented on a change in pull request #2326: libc: Enhance getopt function

juniskane commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r525998185



##########
File path: include/unistd.h
##########
@@ -44,6 +44,8 @@
 #include <sys/types.h>
 #include <nuttx/compiler.h>
 
+#include <getopt.h>

Review comment:
       Should not include this here. Non-standard macros and identifiers in getopt.h can break conforming POSIX programs, for example valid declaration:  `bool no_argument = true;`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org