[jira] [Commented] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

["Duo Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200465#comment-17200465 ] 

Duo Zhang commented on HBASE-25068:
-----------------------------------

Hi, sir, you missed my comments on the PR?

{quote}
Let's change the base branch to master so we can commit the changes to a feature branch first? The patch is small and OK, but at least without the follow-on patches for meta replication, itself is not useful for our current code base...
{quote}

I said it is better to commit the patch to a feature branch first as it is not useful for our current code base...

> Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-25068
>                 URL: https://issues.apache.org/jira/browse/HBASE-25068
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Michael Stack
>            Assignee: Michael Stack
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Small change that passes all WALProviders to ReplicationService rather than just the default/user-space WALProvider. It does this using the WALFactory vessel since it holds all Providers. This change is to be exploited by adjacent sub-task HBASE-25055 in follow-on. This sub-task also exists to make the HBASE-25055 patch smaller and more focused, easier to review.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)