You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lukas Theussl (JIRA)" <ji...@codehaus.org> on 2011/01/07 22:44:57 UTC
[jira] Created: (DOXIASITETOOLS-45) assembleModelInheritance
modifies parent DecorationModel
assembleModelInheritance modifies parent DecorationModel
--------------------------------------------------------
Key: DOXIASITETOOLS-45
URL: http://jira.codehaus.org/browse/DOXIASITETOOLS-45
Project: Maven Doxia Sitetools
Issue Type: Bug
Components: Decoration model
Affects Versions: 1.1.4
Reporter: Lukas Theussl
After calling DefaultDecorationModelInheritanceAssembler.assembleModelInheritance, the parent DecorationModel is usually different from the original. In particular paths get relativized because MenuItems, Links, etc. get referenced instead of copied into the merged model. I think that only the child should be modified after the method returns, as otherwise it is impossible to resolve another child against the same parent. I am not sure if this has any practical consequences, as the DefaultSiteTool does not use the parent anymore after assemblance, but it could well be the source of some subtle bugs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DOXIASITETOOLS-45) assembleModelInheritance
modifies parent DecorationModel
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIASITETOOLS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukas Theussl closed DOXIASITETOOLS-45.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.5
Assignee: Lukas Theussl
Fixed in [r1056527|http://svn.apache.org/viewvc?rev=1056527&view=rev]
> assembleModelInheritance modifies parent DecorationModel
> --------------------------------------------------------
>
> Key: DOXIASITETOOLS-45
> URL: http://jira.codehaus.org/browse/DOXIASITETOOLS-45
> Project: Maven Doxia Sitetools
> Issue Type: Bug
> Components: Decoration model
> Affects Versions: 1.1.4
> Reporter: Lukas Theussl
> Assignee: Lukas Theussl
> Fix For: 1.1.5
>
>
> After calling DefaultDecorationModelInheritanceAssembler.assembleModelInheritance, the parent DecorationModel is usually different from the original. In particular paths get relativized because MenuItems, Links, etc. get referenced instead of copied into the merged model. I think that only the child should be modified after the method returns, as otherwise it is impossible to resolve another child against the same parent. I am not sure if this has any practical consequences, as the DefaultSiteTool does not use the parent anymore after assemblance, but it could well be the source of some subtle bugs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira