You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/30 14:36:02 UTC

[GitHub] mdespriee opened a new pull request #13038: [MXNET-918] Introduce Random module / Refact code generation

mdespriee opened a new pull request #13038: [MXNET-918] Introduce Random module / Refact code generation
URL: https://github.com/apache/incubator-mxnet/pull/13038
 
 
   ## Description ##
   This PR is part of a larger work to introduce Symbol.random and NDArray.random modules in scala API.
   This PR is a refactoring of code-generation (APIDocGenerator, NDArrayMacro, SymbolMacro) to avoid duplication of similar logic.
   
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ## Comments ##
   - This is a continuation of work started in PR https://github.com/apache/incubator-mxnet/pull/12489
   - Work has been separated in 2 PRs to ease review.
   - This PR does not introduce any new functionality
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services