You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/18 12:57:02 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #37570: [SPARK-40120][PYTHON][SQL][DOCS] Make pyspark.sql.readwriter examples self-contained
HyukjinKwon opened a new pull request, #37570:
URL: https://github.com/apache/spark/pull/37570
### What changes were proposed in this pull request?
This PR proposes to improve the examples in `pyspark.sql.readwriter` by making each example self-contained with a brief explanation and a bit more realistic example.
### Why are the changes needed?
To make the documentation more readable and able to copy and paste directly in PySpark shell.
### Does this PR introduce _any_ user-facing change?
Yes, it changes the documentation
### How was this patch tested?
Manually ran each doctests. CI also runs this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37570: [SPARK-40120][PYTHON][SQL][DOCS] Make pyspark.sql.readwriter examples self-contained
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37570:
URL: https://github.com/apache/spark/pull/37570#issuecomment-1220231009
All tests passed.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37570: [SPARK-40120][PYTHON][SQL][DOCS] Make pyspark.sql.readwriter examples self-contained
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37570:
URL: https://github.com/apache/spark/pull/37570#issuecomment-1220173193
cc @zhengruifeng @viirya @xinrong-meng @itholic in case you guys find some time to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37570: [SPARK-40120][PYTHON][SQL][DOCS] Make pyspark.sql.readwriter examples self-contained
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37570:
URL: https://github.com/apache/spark/pull/37570#issuecomment-1220199913
Looks pretty good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37570: [SPARK-40120][PYTHON][SQL][DOCS] Make pyspark.sql.readwriter examples self-contained
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37570: [SPARK-40120][PYTHON][SQL][DOCS] Make pyspark.sql.readwriter examples self-contained
URL: https://github.com/apache/spark/pull/37570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org