You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2022/06/07 09:30:31 UTC

[hop] branch master updated: HOP-3937: incorrect exit code on pipelines when using Abort transform

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/master by this push:
     new a0984adacd HOP-3937: incorrect exit code on pipelines when using Abort transform
     new 78c51b246a Merge pull request #1501 from uraychang/wrongexitcode
a0984adacd is described below

commit a0984adacd78e02ac8388aff7f18a071debec609
Author: ray.chang <ur...@gmail.com>
AuthorDate: Tue May 24 12:20:27 2022 +0800

    HOP-3937: incorrect exit code on pipelines when using Abort transform
---
 engine/src/main/java/org/apache/hop/run/HopRun.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/src/main/java/org/apache/hop/run/HopRun.java b/engine/src/main/java/org/apache/hop/run/HopRun.java
index 6127e2d93e..9bd28ca7db 100644
--- a/engine/src/main/java/org/apache/hop/run/HopRun.java
+++ b/engine/src/main/java/org/apache/hop/run/HopRun.java
@@ -247,7 +247,7 @@ public class HopRun implements Runnable, IHasHopMetadataProvider {
       pipeline.startThreads();
       pipeline.waitUntilFinished();
       // TODO: how to see if a pipeline fails? getresult always return true
-      setFinishedWithoutError(true);
+      setFinishedWithoutError(pipeline.getResult().getNrErrors() == 0l);
     } catch (Exception e) {
       throw new ExecutionException(cmd, "Error running pipeline locally", e);
     }