You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/29 15:54:37 UTC
[GitHub] [shardingsphere] taojintianxia opened a new pull request #5387: Encryption translation
taojintianxia opened a new pull request #5387:
URL: https://github.com/apache/shardingsphere/pull/5387
Fixes #5338
Changes proposed in this pull request:
- translate the encryption document into English
- translate all pictures in encryption CN document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on a change in pull request #5387: Encryption translation
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5387:
URL: https://github.com/apache/shardingsphere/pull/5387#discussion_r417938168
##########
File path: docs/document/content/features/orchestration/encrypt.en.md
##########
@@ -12,6 +12,196 @@ Because of that, ShardingSphere has provided data masking, which stores users' s
ShardingSphere has made the encryption and decryption processes totally transparent to users, who can store desensitized data and acquire original data without any awareness. In addition, ShardingSphere has provided internal masking algorithms, which can be directly used by users. In the same time, we have also provided masking algorithm related interfaces, which can be implemented by users themselves. After simple configurations, ShardingSphere can use algorithms provided by users to perform encryption, decryption and masking.
+## Preface
+
+Apache ShardingSphere is an ecosystem of open source distributed database middleware solutions. It consists of Sharding-JDBC, Sharding-Proxy, and Sharding-Sidecar (in planning) which are independent of each other, but can be used in mixed deployment. All of these can provide standardized data sharding, distributed transactions, and distributed governance functions, and can be applied to various situation such as Java homogeneous, heterogeneous languages, containers, cloud native, and so on.
+
+The data encryption module belongs to the sub-function module under the core function of ShardingSphere distributed governance. It parses the SQL input by the user and rewrites the SQL according to the encryption configuration provided by the user, thereby encrypting the original data and storing the original data and store the original data (optional) and cipher data to database at the same time. When the user queries the data, it takes the cipher data from the database and decrypts it, and finally returns the decrypted original data to the user. Apache ShardingSphere distributed database middleware automates and transparentizes the process of data encryption, so that users do not need to pay attention to the details of data decryption and use decrypted data like ordinary data. In addition, ShardingSphere can provide a relatively complete set of solutions for the encryption of online services or the encryption function of new services.
+
+## Demand Analysis
+
+The demand for data encryption is generally divided into two situations in real business scenarios:
+
+1. When the new business start to launch, and the security department stipulates that the sensitive information related to users, such as banks and mobile phone numbers, should be encrypted and stored in the database, and then decrypted when used. Because it is a brand new system, there is no inventory data cleaning problem, so the implementation is relatively simple.
+
+2. For the service has been launched, and plaintext has been stored in the database before. The relevant department suddenly needs to encrypt the data from the on-line business. This scenario generally needs to deal with three issues as followings:
+__
+ a) How to encrypt the historical data, a.k.a.s wash number.
+
+ b) How to encrypt the newly added data and store it in the database without changing the business SQL and logic; then decrypt the taken out data when use it.
+
+ c) How to securely, seamlessly and transparently migrate business systems between plaintext and ciphertext data
Review comment:
migrate plaintext and ciphertext data between business systems
##########
File path: docs/document/content/features/orchestration/encrypt.en.md
##########
@@ -12,6 +12,196 @@ Because of that, ShardingSphere has provided data masking, which stores users' s
ShardingSphere has made the encryption and decryption processes totally transparent to users, who can store desensitized data and acquire original data without any awareness. In addition, ShardingSphere has provided internal masking algorithms, which can be directly used by users. In the same time, we have also provided masking algorithm related interfaces, which can be implemented by users themselves. After simple configurations, ShardingSphere can use algorithms provided by users to perform encryption, decryption and masking.
+## Preface
+
+Apache ShardingSphere is an ecosystem of open source distributed database middleware solutions. It consists of Sharding-JDBC, Sharding-Proxy, and Sharding-Sidecar (in planning) which are independent of each other, but can be used in mixed deployment. All of these can provide standardized data sharding, distributed transactions, and distributed governance functions, and can be applied to various situation such as Java homogeneous, heterogeneous languages, containers, cloud native, and so on.
+
+The data encryption module belongs to the sub-function module under the core function of ShardingSphere distributed governance. It parses the SQL input by the user and rewrites the SQL according to the encryption configuration provided by the user, thereby encrypting the original data and storing the original data and store the original data (optional) and cipher data to database at the same time. When the user queries the data, it takes the cipher data from the database and decrypts it, and finally returns the decrypted original data to the user. Apache ShardingSphere distributed database middleware automates and transparentizes the process of data encryption, so that users do not need to pay attention to the details of data decryption and use decrypted data like ordinary data. In addition, ShardingSphere can provide a relatively complete set of solutions for the encryption of online services or the encryption function of new services.
+
+## Demand Analysis
+
+The demand for data encryption is generally divided into two situations in real business scenarios:
+
+1. When the new business start to launch, and the security department stipulates that the sensitive information related to users, such as banks and mobile phone numbers, should be encrypted and stored in the database, and then decrypted when used. Because it is a brand new system, there is no inventory data cleaning problem, so the implementation is relatively simple.
+
+2. For the service has been launched, and plaintext has been stored in the database before. The relevant department suddenly needs to encrypt the data from the on-line business. This scenario generally needs to deal with three issues as followings:
+__
Review comment:
a redundant underscore here
##########
File path: docs/document/content/features/orchestration/encrypt.en.md
##########
@@ -12,6 +12,196 @@ Because of that, ShardingSphere has provided data masking, which stores users' s
ShardingSphere has made the encryption and decryption processes totally transparent to users, who can store desensitized data and acquire original data without any awareness. In addition, ShardingSphere has provided internal masking algorithms, which can be directly used by users. In the same time, we have also provided masking algorithm related interfaces, which can be implemented by users themselves. After simple configurations, ShardingSphere can use algorithms provided by users to perform encryption, decryption and masking.
+## Preface
+
+Apache ShardingSphere is an ecosystem of open source distributed database middleware solutions. It consists of Sharding-JDBC, Sharding-Proxy, and Sharding-Sidecar (in planning) which are independent of each other, but can be used in mixed deployment. All of these can provide standardized data sharding, distributed transactions, and distributed governance functions, and can be applied to various situation such as Java homogeneous, heterogeneous languages, containers, cloud native, and so on.
+
+The data encryption module belongs to the sub-function module under the core function of ShardingSphere distributed governance. It parses the SQL input by the user and rewrites the SQL according to the encryption configuration provided by the user, thereby encrypting the original data and storing the original data and store the original data (optional) and cipher data to database at the same time. When the user queries the data, it takes the cipher data from the database and decrypts it, and finally returns the decrypted original data to the user. Apache ShardingSphere distributed database middleware automates and transparentizes the process of data encryption, so that users do not need to pay attention to the details of data decryption and use decrypted data like ordinary data. In addition, ShardingSphere can provide a relatively complete set of solutions for the encryption of online services or the encryption function of new services.
+
+## Demand Analysis
+
+The demand for data encryption is generally divided into two situations in real business scenarios:
+
+1. When the new business start to launch, and the security department stipulates that the sensitive information related to users, such as banks and mobile phone numbers, should be encrypted and stored in the database, and then decrypted when used. Because it is a brand new system, there is no inventory data cleaning problem, so the implementation is relatively simple.
+
+2. For the service has been launched, and plaintext has been stored in the database before. The relevant department suddenly needs to encrypt the data from the on-line business. This scenario generally needs to deal with three issues as followings:
+__
+ a) How to encrypt the historical data, a.k.a.s wash number.
Review comment:
wash number should be clean data
##########
File path: docs/document/content/features/orchestration/encrypt.en.md
##########
@@ -12,6 +12,196 @@ Because of that, ShardingSphere has provided data masking, which stores users' s
ShardingSphere has made the encryption and decryption processes totally transparent to users, who can store desensitized data and acquire original data without any awareness. In addition, ShardingSphere has provided internal masking algorithms, which can be directly used by users. In the same time, we have also provided masking algorithm related interfaces, which can be implemented by users themselves. After simple configurations, ShardingSphere can use algorithms provided by users to perform encryption, decryption and masking.
+## Preface
+
+Apache ShardingSphere is an ecosystem of open source distributed database middleware solutions. It consists of Sharding-JDBC, Sharding-Proxy, and Sharding-Sidecar (in planning) which are independent of each other, but can be used in mixed deployment. All of these can provide standardized data sharding, distributed transactions, and distributed governance functions, and can be applied to various situation such as Java homogeneous, heterogeneous languages, containers, cloud native, and so on.
+
+The data encryption module belongs to the sub-function module under the core function of ShardingSphere distributed governance. It parses the SQL input by the user and rewrites the SQL according to the encryption configuration provided by the user, thereby encrypting the original data and storing the original data and store the original data (optional) and cipher data to database at the same time. When the user queries the data, it takes the cipher data from the database and decrypts it, and finally returns the decrypted original data to the user. Apache ShardingSphere distributed database middleware automates and transparentizes the process of data encryption, so that users do not need to pay attention to the details of data decryption and use decrypted data like ordinary data. In addition, ShardingSphere can provide a relatively complete set of solutions for the encryption of online services or the encryption function of new services.
+
+## Demand Analysis
+
+The demand for data encryption is generally divided into two situations in real business scenarios:
+
+1. When the new business start to launch, and the security department stipulates that the sensitive information related to users, such as banks and mobile phone numbers, should be encrypted and stored in the database, and then decrypted when used. Because it is a brand new system, there is no inventory data cleaning problem, so the implementation is relatively simple.
+
+2. For the service has been launched, and plaintext has been stored in the database before. The relevant department suddenly needs to encrypt the data from the on-line business. This scenario generally needs to deal with three issues as followings:
+__
+ a) How to encrypt the historical data, a.k.a.s wash number.
+
+ b) How to encrypt the newly added data and store it in the database without changing the business SQL and logic; then decrypt the taken out data when use it.
+
+ c) How to securely, seamlessly and transparently migrate business systems between plaintext and ciphertext data
+
+## Detailed Process
+
+### Overall Architecture
+
+Encrypt-JDBC provided by ShardingSphere are deployed with business code. Business parties need to perform JDBC programming for Encrypt-JDBC. Since Encrypt-JDBC implements all JDBC standard interfaces, business codes can be used without additional modification. At this time, Encrypt-JDBC is responsible for all interactions between the business code and the database. Business only needs to provide encryption rules. ** As a bridge between the business code and the underlying database, Encrypt-JDBC can intercept user behavior and interact with the database after transforming the user behavior. **
Review comment:
business codes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #5387: Encryption translation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5387:
URL: https://github.com/apache/shardingsphere/pull/5387#issuecomment-621332736
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=h1) Report
> Merging [#5387](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8e88398e16a4cbf6b4b16eb916973d5412a7c6a3&el=desc) will **increase** coverage by `0.37%`.
> The diff coverage is `73.68%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5387 +/- ##
============================================
+ Coverage 53.61% 53.98% +0.37%
- Complexity 412 419 +7
============================================
Files 1159 1161 +2
Lines 20799 20821 +22
Branches 3761 3759 -2
============================================
+ Hits 11152 11241 +89
+ Misses 8925 8867 -58
+ Partials 722 713 -9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...tegy/algorithm/sharding/HashShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvSGFzaFNoYXJkaW5nQWxnb3JpdGhtLmphdmE=) | `75.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gy/algorithm/sharding/ModuloShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvTW9kdWxvU2hhcmRpbmdBbGdvcml0aG0uamF2YQ==) | `86.36% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../algorithm/sharding/DatetimeShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvRGF0ZXRpbWVTaGFyZGluZ0FsZ29yaXRobS5qYXZh) | `73.68% <73.68%> (+12.14%)` | `0.00 <0.00> (ø)` | |
| [...ngjdbc/jdbc/core/datasource/EncryptDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvZGF0YXNvdXJjZS9FbmNyeXB0RGF0YVNvdXJjZS5qYXZh) | `80.00% <0.00%> (-3.34%)` | `0.00% <0.00%> (ø%)` | |
| [...ml/YamlOrchestrationShardingDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2FwaS95YW1sL1lhbWxPcmNoZXN0cmF0aW9uU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `53.33% <0.00%> (-2.92%)` | `0.00% <0.00%> (ø%)` | |
| [...YamlOrchestrationMasterSlaveDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2FwaS95YW1sL1lhbWxPcmNoZXN0cmF0aW9uTWFzdGVyU2xhdmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `53.33% <0.00%> (-2.92%)` | `0.00% <0.00%> (ø%)` | |
| [...internal/executor/HintShowTableStatusExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3RleHQvc2N0bC9oaW50L2ludGVybmFsL2V4ZWN1dG9yL0hpbnRTaG93VGFibGVTdGF0dXNFeGVjdXRvci5qYXZh) | `90.32% <0.00%> (-1.57%)` | `0.00% <0.00%> (ø%)` | |
| [...gjdbc/jdbc/core/datasource/ShardingDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ0RhdGFTb3VyY2UuamF2YQ==) | `88.88% <0.00%> (-1.12%)` | `0.00% <0.00%> (ø%)` | |
| [...gjdbc/jdbc/core/connection/ShardingConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29ubmVjdGlvbi9TaGFyZGluZ0Nvbm5lY3Rpb24uamF2YQ==) | `77.50% <0.00%> (-1.08%)` | `0.00% <0.00%> (ø%)` | |
| ... and [95 more](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=footer). Last update [f74bd6b...2385347](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5387: Encryption translation
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5387:
URL: https://github.com/apache/shardingsphere/pull/5387#issuecomment-621335305
## Pull Request Test Coverage Report for [Build 11356](https://coveralls.io/builds/30436468)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.528%**
---
| Totals | [](https://coveralls.io/builds/30436468) |
| :-- | --: |
| Change from base [Build 11349](https://coveralls.io/builds/30426921): | 0.0% |
| Covered Lines: | 11918 |
| Relevant Lines: | 20717 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5387: Encryption translation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5387:
URL: https://github.com/apache/shardingsphere/pull/5387#issuecomment-621332736
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=h1) Report
> Merging [#5387](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8e88398e16a4cbf6b4b16eb916973d5412a7c6a3&el=desc) will **increase** coverage by `0.40%`.
> The diff coverage is `73.68%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5387 +/- ##
============================================
+ Coverage 53.61% 54.02% +0.40%
Complexity 412 412
============================================
Files 1159 1150 -9
Lines 20799 20717 -82
Branches 3761 3754 -7
============================================
+ Hits 11152 11192 +40
+ Misses 8925 8812 -113
+ Partials 722 713 -9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...tegy/algorithm/sharding/HashShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvSGFzaFNoYXJkaW5nQWxnb3JpdGhtLmphdmE=) | `75.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gy/algorithm/sharding/ModuloShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvTW9kdWxvU2hhcmRpbmdBbGdvcml0aG0uamF2YQ==) | `86.36% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../algorithm/sharding/DatetimeShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvRGF0ZXRpbWVTaGFyZGluZ0FsZ29yaXRobS5qYXZh) | `73.68% <73.68%> (+12.14%)` | `0.00 <0.00> (ø)` | |
| [...ngjdbc/jdbc/core/datasource/EncryptDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvZGF0YXNvdXJjZS9FbmNyeXB0RGF0YVNvdXJjZS5qYXZh) | `80.00% <0.00%> (-3.34%)` | `0.00% <0.00%> (ø%)` | |
| [...internal/executor/HintShowTableStatusExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3RleHQvc2N0bC9oaW50L2ludGVybmFsL2V4ZWN1dG9yL0hpbnRTaG93VGFibGVTdGF0dXNFeGVjdXRvci5qYXZh) | `90.32% <0.00%> (-1.57%)` | `0.00% <0.00%> (ø%)` | |
| [...gjdbc/jdbc/core/datasource/ShardingDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ0RhdGFTb3VyY2UuamF2YQ==) | `88.88% <0.00%> (-1.12%)` | `0.00% <0.00%> (ø%)` | |
| [...gjdbc/jdbc/core/connection/ShardingConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29ubmVjdGlvbi9TaGFyZGluZ0Nvbm5lY3Rpb24uamF2YQ==) | `77.50% <0.00%> (-1.08%)` | `0.00% <0.00%> (ø%)` | |
| [...ication/jdbc/wrapper/StatementExecutorWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1N0YXRlbWVudEV4ZWN1dG9yV3JhcHBlci5qYXZh) | `5.88% <0.00%> (-0.57%)` | `0.00% <0.00%> (ø%)` | |
| [...jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1ByZXBhcmVkU3RhdGVtZW50RXhlY3V0b3JXcmFwcGVyLmphdmE=) | `5.88% <0.00%> (-0.57%)` | `0.00% <0.00%> (ø%)` | |
| ... and [65 more](https://codecov.io/gh/apache/shardingsphere/pull/5387/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=footer). Last update [f74bd6b...8874440](https://codecov.io/gh/apache/shardingsphere/pull/5387?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #5387: Encryption translation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5387:
URL: https://github.com/apache/shardingsphere/pull/5387#issuecomment-621335305
## Pull Request Test Coverage Report for [Build 11384](https://coveralls.io/builds/30468696)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **50** unchanged lines in **9** files lost coverage.
* Overall coverage decreased (**-0.05%**) to **57.476%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationMasterSlaveDataSourceFactory.java](https://coveralls.io/builds/30468696/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationMasterSlaveDataSourceFactory.java#L117) | 1 | 60.0% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/30468696/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L118) | 1 | 60.0% |
| [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/30468696/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L191) | 1 | 95.35% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/internal/datasource/OrchestrationShardingDataSource.java](https://coveralls.io/builds/30468696/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Finternal%2Fdatasource%2FOrchestrationShardingDataSource.java#L91) | 2 | 89.36% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/MasterSlaveRule.java](https://coveralls.io/builds/30468696/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FMasterSlaveRule.java#L58) | 5 | 69.23% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/30468696/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L55) | 5 | 58.82% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/MasterSlaveSchema.java](https://coveralls.io/builds/30468696/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FMasterSlaveSchema.java#L41) | 6 | 0% |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/30468696/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L337) | 11 | 86.08% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/30468696/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L50) | 18 | 0% |
<!-- | **Total:** | **50** | | -->
| Totals | [](https://coveralls.io/builds/30468696) |
| :-- | --: |
| Change from base [Build 11349](https://coveralls.io/builds/30426921): | -0.05% |
| Covered Lines: | 11967 |
| Relevant Lines: | 20821 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org