[GitHub] [arrow] zeroshade commented on a diff in pull request #35191: GH-35190: [Go] Correctly handle null values in CSV reader

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #35191:
URL: https://github.com/apache/arrow/pull/35191#discussion_r1168865762


##########
go/arrow/csv/reader.go:
##########
@@ -767,7 +767,7 @@ func (r *Reader) parseList(field array.Builder, str string) {
 
 func (r *Reader) parseBinaryType(field array.Builder, str string) {
 	// specialize the implementation when we know we cannot have nulls
-	if str != "" && r.isNull(str) {
+	if r.isNull(str) {
 		field.AppendNull()
 		return
 	}

Review Comment:
   Do we currently have a test that verifies you can still get an empty string if it is not in the list of Null values? / `stringsCanBeNull` == `false` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org