[jira] [Work logged] (BEAM-8376) Add FirestoreIO connector to Java SDK

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-8376?focusedWorklogId=648904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648904 ]

ASF GitHub Bot logged work on BEAM-8376:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Sep/21 22:30
            Start Date: 09/Sep/21 22:30
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request #15425:
URL: https://github.com/apache/beam/pull/15425#discussion_r705748044



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1.java
##########
@@ -1218,6 +1218,9 @@ public void processElement(ProcessContext c) {
         List<Cursor> cursors = new ArrayList<>(partitionQueryResponse.getPartitionsList());
         cursors.sort(CURSOR_REFERENCE_VALUE_COMPARATOR);
         final int size = cursors.size();
+        if (size == 0) {
+          emit(c, dbRoot, structuredQuery.toBuilder());

Review comment:
       Should we just return here ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 648904)
    Time Spent: 40h 40m  (was: 40.5h)

> Add FirestoreIO connector to Java SDK
> -------------------------------------
>
>                 Key: BEAM-8376
>                 URL: https://issues.apache.org/jira/browse/BEAM-8376
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-gcp
>            Reporter: Stefan Djelekar
>            Assignee: Ben Whitehead
>            Priority: P3
>             Fix For: 2.34.0
>
>          Time Spent: 40h 40m
>  Remaining Estimate: 0h
>
> Motivation:
> There is no Firestore connector for Java SDK at the moment.
> Having it will enhance the integrations with database options on the Google Cloud Platform.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)