[jira] [Commented] (MNG-7448) Don't ignore bin/ otherwise bin/ in apache-maven module cannot be readded

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537081#comment-17537081 ] 

ASF GitHub Bot commented on MNG-7448:
-------------------------------------

michael-o opened a new pull request, #742:
URL: https://github.com/apache/maven/pull/742

   …nnot be readded
   
   This closes #742
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue. Your pull request should address just this issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
          and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
          title in the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Don't ignore bin/ otherwise bin/ in apache-maven module cannot be readded
> -------------------------------------------------------------------------
>
>                 Key: MNG-7448
>                 URL: https://issues.apache.org/jira/browse/MNG-7448
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.8.5
>            Reporter: Daqian Liao
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>         Attachments: bin.png, image-2022-05-06-20-32-09-746.png
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> when we download sourcecode, and push code to github, the apache-maven/src/bin directory will not be pushed.
> If we delete bin directory in apache-maven/src, we can not find because git has ignore it .
> The reason is that .gitignore file contains bin at line 6。
> fix: delete bin/ from .gitignore
> !bin.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)