You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/10 16:24:16 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #10030: chore(security): Renaming schemas_accessible_by_user
john-bodley opened a new pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030
### SUMMARY
This PR renames the `schemas_accessible_by_user` function to `get_schemas_accessible_by_user` which is consistent with the `get_datasources_accessible_by_user` method.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `4.81%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 65.66% -4.82%
==========================================
Files 583 583
Lines 31019 31019
Branches 3175 3175
==========================================
- Hits 21861 20368 -1493
- Misses 9049 10473 +1424
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `70.06% <50.00%> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <50.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [140 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...d824716](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 70.01% -0.46%
==========================================
Files 583 184 -399
Lines 31019 18182 -12837
Branches 3175 0 -3175
==========================================
- Hits 21861 12731 -9130
+ Misses 9049 5451 -3598
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.01% <50.00%> (-0.05%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <50.00%> (-0.22%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.80% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [399 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...a44063b](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 583 583
Lines 31019 31019
Branches 3175 3175
=======================================
+ Hits 21861 21862 +1
+ Misses 9049 9048 -1
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.93% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `70.06% <50.00%> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <50.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (+1.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...d824716](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642165341
@villebro I think that's generally a good idea however for https://github.com/apache/incubator-superset/pull/10031 (which is similar) there's actually name conflicts due the renaming and thus it is not viable to keep both the old and new forms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `6.98%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 63.49% -6.99%
==========================================
Files 583 529 -54
Lines 31019 29574 -1445
Branches 3175 2838 -337
==========================================
- Hits 21861 18778 -3083
- Misses 9049 10612 +1563
- Partials 109 184 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.08% <ø> (-0.85%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `70.01% <50.00%> (-0.05%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <50.00%> (-0.22%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [214 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...a44063b](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `6.61%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 63.86% -6.62%
==========================================
Files 583 529 -54
Lines 31019 29574 -1445
Branches 3175 2838 -337
==========================================
- Hits 21861 18887 -2974
- Misses 9049 10512 +1463
- Partials 109 175 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.92% <ø> (ø)` | |
| #javascript | `?` | |
| #python | `70.09% <50.00%> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <50.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [208 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...a44063b](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.63%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 69.83% -0.64%
==========================================
Files 583 184 -399
Lines 31019 18182 -12837
Branches 3175 0 -3175
==========================================
- Hits 21861 12698 -9163
+ Misses 9049 5484 -3565
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.83% <50.00%> (-0.23%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <50.00%> (-0.22%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.69% <100.00%> (-0.35%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| ... and [408 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...a44063b](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `6.62%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 63.85% -6.63%
==========================================
Files 583 529 -54
Lines 31019 29583 -1436
Branches 3175 2838 -337
==========================================
- Hits 21861 18889 -2972
- Misses 9049 10519 +1470
- Partials 109 175 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.92% <ø> (ø)` | |
| #javascript | `?` | |
| #python | `70.06% <50.00%> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <50.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [205 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...a44063b](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 70.09% -0.39%
==========================================
Files 583 184 -399
Lines 31019 18182 -12837
Branches 3175 0 -3175
==========================================
- Hits 21861 12744 -9117
+ Misses 9049 5438 -3611
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.09% <50.00%> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <50.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/addSlice/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL2luZGV4LmpzeA==) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
| ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...d824716](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **not change** coverage.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 583 583
Lines 31019 31019
Branches 3175 3175
=======================================
Hits 21861 21861
Misses 9049 9049
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.92% <ø> (ø)` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `70.06% <50.00%> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <50.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...a44063b](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.63%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 69.83% -0.64%
==========================================
Files 583 184 -399
Lines 31019 18182 -12837
Branches 3175 0 -3175
==========================================
- Hits 21861 12698 -9163
+ Misses 9049 5484 -3565
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.83% <50.00%> (-0.23%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <50.00%> (-0.22%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.69% <100.00%> (-0.35%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| ... and [408 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...d824716](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10030: chore(security): Renaming schemas_accessible_by_user
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10030:
URL: https://github.com/apache/incubator-superset/pull/10030#issuecomment-642122167
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=h1) Report
> Merging [#10030](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.40%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10030 +/- ##
==========================================
- Coverage 70.47% 70.06% -0.41%
==========================================
Files 583 184 -399
Lines 31019 18191 -12828
Branches 3175 0 -3175
==========================================
- Hits 21861 12746 -9115
+ Misses 9049 5445 -3604
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.06% <50.00%> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <50.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [...perset-frontend/src/components/Menu/MenuObject.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LmpzeA==) | | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | | |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| [...nd/src/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=) | | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | | |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | | |
| ... and [392 more](https://codecov.io/gh/apache/incubator-superset/pull/10030/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=footer). Last update [e17da58...d824716](https://codecov.io/gh/apache/incubator-superset/pull/10030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org