You are viewing a plain text version of this content. The canonical link for it is here.
Posted to easyant-dev@incubator.apache.org by Nicolas Lalevée <ni...@hibnet.org> on 2011/07/27 15:52:58 UTC
Clean up of some IP issues
We are missing some IP clearance of one of the original committer of Easyant, so we must clean up the code.
Then find attached the 3 files about the commits gathered on easyant initial svn:
* revs.txt.gz contains every commit revision involved.
* diff.txt.gz contains every diff of thoses revision.
* blame.txt.gz contains every line of every svn annotate of the missing IP (the sort of different view of the previous file).
Re: Clean up of some IP issues
Posted by Jean-Louis Boudart <je...@gmail.com>.
Note : when i used "remove" word i mean remove it from SVN and rewrite it
from scratch differrently.
2011/7/28 Jean-Louis Boudart <je...@gmail.com>
>
>
> Le 27 juillet 2011 17:52, Nicolas Lalevée <ni...@hibnet.org> a
> écrit :
>
>>
>> So, I have reviewed every revisions. I see 3 categories of commits.
>>
> So many thanks for this quick review !
>
>
>
>> About the second, here is the list that I have gathered:
>> - get rid of everything under src/integration-test
>>
> +1
>
>> - remove the xooki plugin
>>
> As far as i know those change only affect the generation of menu entry
> (through menu generator) so removing his commit can make sense but not the
> whole plugin
>
> - remove the menu generator
>>
> - remove the eadoc plugin
>>
> I originally developped the menu generator mechanism, then someone improved
> it a lot with a concrete implementation to generate menu entry on xooki and
> eadoc plugin.
> Removing eadoc plugin can make sense as we will probably need a different
> mechanism to generate plugin documentation as we plan to have external
> plugins. Removing the xooki-menu-generator make sense too.
>
>
>> - remove the docbook plugin
>>
> +1
>
> - get rid of the patch of antunit and ivy (they all are already backported
>> to their project, aren't they?)
>>
> All patches has been applied so we can remove it
>
>
>
>> - get rid of src/test/antunit : there might be debate here, but there's a
>> lots a stuff there. For everybody sake, it will be a lot simpler to just
>> drop it
>>
>
> +1 it make particular sense as plugins test was mixed in easyant-core
> before. In the new architecture, each plugins will have their own test
>
>
>> - idem for the antunit, coverage, cobertura, emma plugins
>>
> +1 to rewrite / rethink thoses plugins
> Did you voluntary forgot the "package-test-jar" plugin ? It's a really
> simple plugin making a jar of test classes (not sure there's lot of IP
> there)
>
>
>> - a sum of diff to revert, see diff-to-revert.txt
>>
> +1 it i remember those commits hacked the shell script (and the module.ant)
> to limit the size of easyant distribution. Until now we were shipping a
> "third-party-repository" containing many external libs including ivy, and
> ant used to build easyant itself. Thoses jars were also distributed in a
> "lib/" directory and used at runtime. As we now plan to have an online
> repository i think we can get rid of third-party-repository.
>
>
>
>>
>> About the third, if anybody have to time to see the commits, he is
>> welcomed to help decide what we can do about it. See the diff-to-decide.txt
>>
> Here are my comments based on your diff-to-decide :
> r517 : factorize a set of <fileset> to create easyant distribution => not
> sure we can't get rid of this
> In the same commit modification on shell scripts doesn't seems to be
> related => could be reverted
> r492 : his a workaround for a strange bug when ant locates ANT_HOME =>
> should be kept
> r491: nothing to do it was for debug the commit has been already reverted
> => nothing to do
> r490: seems like experimentation things related to ANT_HOME (the real fix
> is r492) => can be reverted
> r489: invokes explicitly the generation of plugin documentation => can be
> reverted
> r487: fixes unit test and performance improvement of module resolution and
> repository report => not sure we can remove this
> r485: huge enhancement on JarResolver's implementation (repository in a
> jar) => not sure we can remove this
> r485: jarresolver enhancement + repository resolver enhancement => not sure
> we can remove this
> r428: i think most of the code here doesn't exist now has it has been
> migrated in a separated plugin (package-test-jar) => nothing to do
> r427: enhancement on Import task, it was supposed to make or test easier =>
> can be reverted also related
> rest of the commit impacts antunit / test-utils => can be removed
> r270: seems a short patch on submodule, it has been refactored a lot => i
> would say nothing to do :)
> r239: almost all the documentation of multimodule => ???
> r232: tiny changes on build-tools v0.1 plugin (multi module) this plugin is
> now deprecated => can be removed from SVN
> r207,205: css changes + introduces two new documentation pages
> -buildtypes.html and plugins.html => ???
>
> --
> Jean Louis Boudart
> Independent consultant
> Apache EasyAnt commiter http://incubator.apache.org/easyant/
>
--
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://incubator.apache.org/easyant/
Re: Clean up of some IP issues
Posted by Nicolas Lalevée <ni...@hibnet.org>.
Le 28 juil. 2011 à 13:38, Jean-Louis Boudart a écrit :
>> - remove the xooki plugin
>>
> As far as i know those change only affect the generation of menu entry
> (through menu generator) so removing his commit can make sense but not the
> whole plugin
You're right. No need to remove the entire plugin, just the few line which has been wrote.
>> - idem for the antunit, coverage, cobertura, emma plugins
>>
> +1 to rewrite / rethink thoses plugins
> Did you voluntary forgot the "package-test-jar" plugin ? It's a really
> simple plugin making a jar of test classes (not sure there's lot of IP
> there)
hum, interesting. I didn't see this with the list of commits. There is no commit with IP issue on package-test-jar, but package-test-jar has Ip issues because it has been copied from package-jar, indicated by the svn blames.
As soon as we agree on how to clean up package-jar, we could do the same with package-test-jar I think.
>>
>> About the third, if anybody have to time to see the commits, he is welcomed
>> to help decide what we can do about it. See the diff-to-decide.txt
>>
> Here are my comments based on your diff-to-decide :
> r517 : factorize a set of <fileset> to create easyant distribution => not
> sure we can't get rid of this
> In the same commit modification on shell scripts doesn't seems to be
> related => could be reverted
> r492 : his a workaround for a strange bug when ant locates ANT_HOME =>
> should be kept
> r491: nothing to do it was for debug the commit has been already reverted =>
> nothing to do
> r490: seems like experimentation things related to ANT_HOME (the real fix is
> r492) => can be reverted
> r489: invokes explicitly the generation of plugin documentation => can be
> reverted
> r487: fixes unit test and performance improvement of module resolution and
> repository report => not sure we can remove this
> r485: huge enhancement on JarResolver's implementation (repository in a jar)
> => not sure we can remove this
> r485: jarresolver enhancement + repository resolver enhancement => not sure
> we can remove this
> r428: i think most of the code here doesn't exist now has it has been
> migrated in a separated plugin (package-test-jar) => nothing to do
> r427: enhancement on Import task, it was supposed to make or test easier =>
> can be reverted also related
> rest of the commit impacts antunit / test-utils => can be removed
> r270: seems a short patch on submodule, it has been refactored a lot => i
> would say nothing to do :)
> r239: almost all the documentation of multimodule => ???
> r232: tiny changes on build-tools v0.1 plugin (multi module) this plugin is
> now deprecated => can be removed from SVN
> r207,205: css changes + introduces two new documentation pages
> -buildtypes.html and plugins.html => ???
I'll proceed your comments later.
cheers,
Nicolas
Re: Clean up of some IP issues
Posted by Nicolas Lalevée <ni...@hibnet.org>.
Le 28 juil. 2011 à 13:38, Jean-Louis Boudart a écrit :
>> About the third, if anybody have to time to see the commits, he is welcomed
>> to help decide what we can do about it. See the diff-to-decide.txt
>>
> Here are my comments based on your diff-to-decide :
> r517 : factorize a set of <fileset> to create easyant distribution => not
> sure we can't get rid of this
finally it seems to be just some fileset moves, doesn't seems to have much IP. Added to diff-to-keep-2.txt
> In the same commit modification on shell scripts doesn't seems to be
> related => could be reverted
added to diff-to-revert-2.txt
> r492 : his a workaround for a strange bug when ant locates ANT_HOME =>
> should be kept
I've added it to a diff-to-keep-2.txt
> r491: nothing to do it was for debug the commit has been already reverted =>
> nothing to do
I've checked, you're right. Already reverted.
> r490: seems like experimentation things related to ANT_HOME (the real fix is
> r492) => can be reverted
added to diff-to-revert-2.txt
> r489: invokes explicitly the generation of plugin documentation => can be
> reverted
added to diff-to-revert-2.txt
> r487: fixes unit test and performance improvement of module resolution and
> repository report => not sure we can remove this
if it's just performance improvement, it's not critical to remove it, right ? We could improve the performance later
> r485: huge enhancement on JarResolver's implementation (repository in a jar)
> => not sure we can remove this
> r485: jarresolver enhancement + repository resolver enhancement => not sure
> we can remove this
can we imagine we get rid of the jar resolver and implement a zip resolver ?
> r428: i think most of the code here doesn't exist now has it has been
> migrated in a separated plugin (package-test-jar) => nothing to do
well, some code has been moved, but the IP is still there.
Maybe we can get rid of the existing package-test-jar and reimplement it ?
> r427: enhancement on Import task, it was supposed to make or test easier =>
> can be reverted also related
> rest of the commit impacts antunit / test-utils => can be removed
added to diff-to-revert-2.txt
> r270: seems a short patch on submodule, it has been refactored a lot => i
> would say nothing to do :)
you're right, I cannot find the code in the trunk
> r239: almost all the documentation of multimodule => ???
> r232: tiny changes on build-tools v0.1 plugin (multi module) this plugin is
> now deprecated => can be removed from SVN
ok let's get rid of it.
> r207,205: css changes + introduces two new documentation pages
> -buildtypes.html and plugins.html => ???
I don't know what to do about docs
thanks for your help.
Nicolas
Re: Clean up of some IP issues
Posted by Jean-Louis Boudart <je...@gmail.com>.
Le 27 juillet 2011 17:52, Nicolas Lalevée <ni...@hibnet.org> a
écrit :
>
> So, I have reviewed every revisions. I see 3 categories of commits.
>
So many thanks for this quick review !
> About the second, here is the list that I have gathered:
> - get rid of everything under src/integration-test
>
+1
> - remove the xooki plugin
>
As far as i know those change only affect the generation of menu entry
(through menu generator) so removing his commit can make sense but not the
whole plugin
- remove the menu generator
>
- remove the eadoc plugin
>
I originally developped the menu generator mechanism, then someone improved
it a lot with a concrete implementation to generate menu entry on xooki and
eadoc plugin.
Removing eadoc plugin can make sense as we will probably need a different
mechanism to generate plugin documentation as we plan to have external
plugins. Removing the xooki-menu-generator make sense too.
> - remove the docbook plugin
>
+1
- get rid of the patch of antunit and ivy (they all are already backported
> to their project, aren't they?)
>
All patches has been applied so we can remove it
> - get rid of src/test/antunit : there might be debate here, but there's a
> lots a stuff there. For everybody sake, it will be a lot simpler to just
> drop it
>
+1 it make particular sense as plugins test was mixed in easyant-core
before. In the new architecture, each plugins will have their own test
> - idem for the antunit, coverage, cobertura, emma plugins
>
+1 to rewrite / rethink thoses plugins
Did you voluntary forgot the "package-test-jar" plugin ? It's a really
simple plugin making a jar of test classes (not sure there's lot of IP
there)
> - a sum of diff to revert, see diff-to-revert.txt
>
+1 it i remember those commits hacked the shell script (and the module.ant)
to limit the size of easyant distribution. Until now we were shipping a
"third-party-repository" containing many external libs including ivy, and
ant used to build easyant itself. Thoses jars were also distributed in a
"lib/" directory and used at runtime. As we now plan to have an online
repository i think we can get rid of third-party-repository.
>
> About the third, if anybody have to time to see the commits, he is welcomed
> to help decide what we can do about it. See the diff-to-decide.txt
>
Here are my comments based on your diff-to-decide :
r517 : factorize a set of <fileset> to create easyant distribution => not
sure we can't get rid of this
In the same commit modification on shell scripts doesn't seems to be
related => could be reverted
r492 : his a workaround for a strange bug when ant locates ANT_HOME =>
should be kept
r491: nothing to do it was for debug the commit has been already reverted =>
nothing to do
r490: seems like experimentation things related to ANT_HOME (the real fix is
r492) => can be reverted
r489: invokes explicitly the generation of plugin documentation => can be
reverted
r487: fixes unit test and performance improvement of module resolution and
repository report => not sure we can remove this
r485: huge enhancement on JarResolver's implementation (repository in a jar)
=> not sure we can remove this
r485: jarresolver enhancement + repository resolver enhancement => not sure
we can remove this
r428: i think most of the code here doesn't exist now has it has been
migrated in a separated plugin (package-test-jar) => nothing to do
r427: enhancement on Import task, it was supposed to make or test easier =>
can be reverted also related
rest of the commit impacts antunit / test-utils => can be removed
r270: seems a short patch on submodule, it has been refactored a lot => i
would say nothing to do :)
r239: almost all the documentation of multimodule => ???
r232: tiny changes on build-tools v0.1 plugin (multi module) this plugin is
now deprecated => can be removed from SVN
r207,205: css changes + introduces two new documentation pages
-buildtypes.html and plugins.html => ???
--
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://incubator.apache.org/easyant/
Re: Clean up of some IP issues
Posted by Nicolas Lalevée <ni...@hibnet.org>.
done for the revert.
Nicolas
Le 5 août 2011 à 20:45, Jean-Louis Boudart a écrit :
> Feel free to revert the content of diff-to-revert.
> As mentioned earlier, those changes mainly affects tiny optimisation on
> easyant shell scripts. Thoses optimisation were introduced to ship a third
> party repository containing all easyant dependencies for core (ant,ivy).
>
> As we plan to have an online repository i think we can get rid of
> third-party-repository. For me revert those change is not an option but a
> real step to have our online repo.
>
>
> Le 5 août 2011 17:42, Nicolas Lalevée <ni...@hibnet.org> a écrit :
>
>> Unless somebody objects, I'll start to do the revert of content of
>> diff-to-revert.txt
>>
>> Nicolas
>>
>> Le 5 août 2011 à 14:02, Nicolas Lalevée a écrit :
>>
>>> done.
>>> And also the clean up of the xooki plugin.
>>>
>>> Nicolas
>>>
>>> Le 3 août 2011 à 18:49, Nicolas Lalevée a écrit :
>>>
>>>> I would like to start clean up the things everybody has agrees on or
>> there is no question about it.
>>>> So unless some has some objection, I will:
>>>> - get rid of everything under src/integration-test
>>>> - remove the menu generator
>>>> - remove the eadoc plugin
>>>> - remove the docbook plugin
>>>> - get rid of the patch of antunit and ivy
>>>> - get rid of src/test/antunit
>>>> - get rid of the plugins antunit, coverage, cobertura, emma
>>>>
>>>> I'll look closer to the remaining code to clean.
>>>>
>>>> Nicolas
>>>>
>>>> Le 28 juil. 2011 à 15:26, Jean-Louis Boudart a écrit :
>>>>
>>>>> I've just created a few JIRAs related on all this stuff, as Stefan
>>>>> suggested.
>>>>>
>>>>> Le 28 juillet 2011 14:36, Stefan Bodewig <bo...@apache.org> a écrit
>> :
>>>>>
>>>>>> On 2011-07-27, Nicolas Lalevée wrote:
>>>>>>
>>>>>>> Then there are the commits which cannot be kept and can be easily
>>>>>>> reverted.
>>>>>>
>>>>>>> And finally the commits I don't know what to do about because they
>>>>>>> seems quite important to easyant but there's some IP on it I think.
>>>>>>
>>>>>> My suggestion would be to open JIRAs for all things that have to be
>>>>>> reverted and that you still want to keep as part of EasyAnt in some
>> way.
>>>>>> That way others can jump in and provide an implementation of their
>> own.
>>>>>>
>>>>>> For example if you have a JIRA that says "the shell script fails doing
>>>>>> FOO if ANT_HOME isn't set", then all that is required is some bash
>>>>>> knowledge and no deep understanding of EasyAnt and even I might be
>> able
>>>>>> to contribute.
>>>>>>
>>>>>> If the contribution is significant, there is no way other than to
>>>>>> revert/remove it and have anybody else provide a different approach.
>>>>>> The earlier we do this, the easier it is going to be.
>>>>>>
>>>>>>> So about the first category, I think the mentors should review the
>>>>>>> part of the diff about these commits, see the attached
>>>>>>> diff-to-keep.txt.
>>>>>>
>>>>>> I went through your list and am comfortable with it.
>>>>>>
>>>>>>> About the second, here is the list that I have gathered:
>>>>>>
>>>>>>> - remove the xooki plugin
>>>>>>> - remove the menu generator
>>>>>>> - remove the eadoc plugin
>>>>>>> - remove the docbook plugin
>>>>>>
>>>>>> "provide a XY plugin" makes an excelent feature requests in JIRA.
>>>>>>
>>>>>> Stefan
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Jean Louis Boudart
>>>>> Independent consultant
>>>>> Apache EasyAnt commiter http://incubator.apache.org/easyant/
>>>>
>>>
>>
>>
>
>
> --
> Jean Louis Boudart
> Independent consultant
> Apache EasyAnt commiter http://incubator.apache.org/easyant/
Re: Clean up of some IP issues
Posted by Jean-Louis Boudart <je...@gmail.com>.
Feel free to revert the content of diff-to-revert.
As mentioned earlier, those changes mainly affects tiny optimisation on
easyant shell scripts. Thoses optimisation were introduced to ship a third
party repository containing all easyant dependencies for core (ant,ivy).
As we plan to have an online repository i think we can get rid of
third-party-repository. For me revert those change is not an option but a
real step to have our online repo.
Le 5 août 2011 17:42, Nicolas Lalevée <ni...@hibnet.org> a écrit :
> Unless somebody objects, I'll start to do the revert of content of
> diff-to-revert.txt
>
> Nicolas
>
> Le 5 août 2011 à 14:02, Nicolas Lalevée a écrit :
>
> > done.
> > And also the clean up of the xooki plugin.
> >
> > Nicolas
> >
> > Le 3 août 2011 à 18:49, Nicolas Lalevée a écrit :
> >
> >> I would like to start clean up the things everybody has agrees on or
> there is no question about it.
> >> So unless some has some objection, I will:
> >> - get rid of everything under src/integration-test
> >> - remove the menu generator
> >> - remove the eadoc plugin
> >> - remove the docbook plugin
> >> - get rid of the patch of antunit and ivy
> >> - get rid of src/test/antunit
> >> - get rid of the plugins antunit, coverage, cobertura, emma
> >>
> >> I'll look closer to the remaining code to clean.
> >>
> >> Nicolas
> >>
> >> Le 28 juil. 2011 à 15:26, Jean-Louis Boudart a écrit :
> >>
> >>> I've just created a few JIRAs related on all this stuff, as Stefan
> >>> suggested.
> >>>
> >>> Le 28 juillet 2011 14:36, Stefan Bodewig <bo...@apache.org> a écrit
> :
> >>>
> >>>> On 2011-07-27, Nicolas Lalevée wrote:
> >>>>
> >>>>> Then there are the commits which cannot be kept and can be easily
> >>>>> reverted.
> >>>>
> >>>>> And finally the commits I don't know what to do about because they
> >>>>> seems quite important to easyant but there's some IP on it I think.
> >>>>
> >>>> My suggestion would be to open JIRAs for all things that have to be
> >>>> reverted and that you still want to keep as part of EasyAnt in some
> way.
> >>>> That way others can jump in and provide an implementation of their
> own.
> >>>>
> >>>> For example if you have a JIRA that says "the shell script fails doing
> >>>> FOO if ANT_HOME isn't set", then all that is required is some bash
> >>>> knowledge and no deep understanding of EasyAnt and even I might be
> able
> >>>> to contribute.
> >>>>
> >>>> If the contribution is significant, there is no way other than to
> >>>> revert/remove it and have anybody else provide a different approach.
> >>>> The earlier we do this, the easier it is going to be.
> >>>>
> >>>>> So about the first category, I think the mentors should review the
> >>>>> part of the diff about these commits, see the attached
> >>>>> diff-to-keep.txt.
> >>>>
> >>>> I went through your list and am comfortable with it.
> >>>>
> >>>>> About the second, here is the list that I have gathered:
> >>>>
> >>>>> - remove the xooki plugin
> >>>>> - remove the menu generator
> >>>>> - remove the eadoc plugin
> >>>>> - remove the docbook plugin
> >>>>
> >>>> "provide a XY plugin" makes an excelent feature requests in JIRA.
> >>>>
> >>>> Stefan
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Jean Louis Boudart
> >>> Independent consultant
> >>> Apache EasyAnt commiter http://incubator.apache.org/easyant/
> >>
> >
>
>
--
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://incubator.apache.org/easyant/
Re: Clean up of some IP issues
Posted by Nicolas Lalevée <ni...@hibnet.org>.
Unless somebody objects, I'll start to do the revert of content of diff-to-revert.txt
Nicolas
Le 5 août 2011 à 14:02, Nicolas Lalevée a écrit :
> done.
> And also the clean up of the xooki plugin.
>
> Nicolas
>
> Le 3 août 2011 à 18:49, Nicolas Lalevée a écrit :
>
>> I would like to start clean up the things everybody has agrees on or there is no question about it.
>> So unless some has some objection, I will:
>> - get rid of everything under src/integration-test
>> - remove the menu generator
>> - remove the eadoc plugin
>> - remove the docbook plugin
>> - get rid of the patch of antunit and ivy
>> - get rid of src/test/antunit
>> - get rid of the plugins antunit, coverage, cobertura, emma
>>
>> I'll look closer to the remaining code to clean.
>>
>> Nicolas
>>
>> Le 28 juil. 2011 à 15:26, Jean-Louis Boudart a écrit :
>>
>>> I've just created a few JIRAs related on all this stuff, as Stefan
>>> suggested.
>>>
>>> Le 28 juillet 2011 14:36, Stefan Bodewig <bo...@apache.org> a écrit :
>>>
>>>> On 2011-07-27, Nicolas Lalevée wrote:
>>>>
>>>>> Then there are the commits which cannot be kept and can be easily
>>>>> reverted.
>>>>
>>>>> And finally the commits I don't know what to do about because they
>>>>> seems quite important to easyant but there's some IP on it I think.
>>>>
>>>> My suggestion would be to open JIRAs for all things that have to be
>>>> reverted and that you still want to keep as part of EasyAnt in some way.
>>>> That way others can jump in and provide an implementation of their own.
>>>>
>>>> For example if you have a JIRA that says "the shell script fails doing
>>>> FOO if ANT_HOME isn't set", then all that is required is some bash
>>>> knowledge and no deep understanding of EasyAnt and even I might be able
>>>> to contribute.
>>>>
>>>> If the contribution is significant, there is no way other than to
>>>> revert/remove it and have anybody else provide a different approach.
>>>> The earlier we do this, the easier it is going to be.
>>>>
>>>>> So about the first category, I think the mentors should review the
>>>>> part of the diff about these commits, see the attached
>>>>> diff-to-keep.txt.
>>>>
>>>> I went through your list and am comfortable with it.
>>>>
>>>>> About the second, here is the list that I have gathered:
>>>>
>>>>> - remove the xooki plugin
>>>>> - remove the menu generator
>>>>> - remove the eadoc plugin
>>>>> - remove the docbook plugin
>>>>
>>>> "provide a XY plugin" makes an excelent feature requests in JIRA.
>>>>
>>>> Stefan
>>>>
>>>
>>>
>>>
>>> --
>>> Jean Louis Boudart
>>> Independent consultant
>>> Apache EasyAnt commiter http://incubator.apache.org/easyant/
>>
>
Re: Clean up of some IP issues
Posted by Nicolas Lalevée <ni...@hibnet.org>.
done.
And also the clean up of the xooki plugin.
Nicolas
Le 3 août 2011 à 18:49, Nicolas Lalevée a écrit :
> I would like to start clean up the things everybody has agrees on or there is no question about it.
> So unless some has some objection, I will:
> - get rid of everything under src/integration-test
> - remove the menu generator
> - remove the eadoc plugin
> - remove the docbook plugin
> - get rid of the patch of antunit and ivy
> - get rid of src/test/antunit
> - get rid of the plugins antunit, coverage, cobertura, emma
>
> I'll look closer to the remaining code to clean.
>
> Nicolas
>
> Le 28 juil. 2011 à 15:26, Jean-Louis Boudart a écrit :
>
>> I've just created a few JIRAs related on all this stuff, as Stefan
>> suggested.
>>
>> Le 28 juillet 2011 14:36, Stefan Bodewig <bo...@apache.org> a écrit :
>>
>>> On 2011-07-27, Nicolas Lalevée wrote:
>>>
>>>> Then there are the commits which cannot be kept and can be easily
>>>> reverted.
>>>
>>>> And finally the commits I don't know what to do about because they
>>>> seems quite important to easyant but there's some IP on it I think.
>>>
>>> My suggestion would be to open JIRAs for all things that have to be
>>> reverted and that you still want to keep as part of EasyAnt in some way.
>>> That way others can jump in and provide an implementation of their own.
>>>
>>> For example if you have a JIRA that says "the shell script fails doing
>>> FOO if ANT_HOME isn't set", then all that is required is some bash
>>> knowledge and no deep understanding of EasyAnt and even I might be able
>>> to contribute.
>>>
>>> If the contribution is significant, there is no way other than to
>>> revert/remove it and have anybody else provide a different approach.
>>> The earlier we do this, the easier it is going to be.
>>>
>>>> So about the first category, I think the mentors should review the
>>>> part of the diff about these commits, see the attached
>>>> diff-to-keep.txt.
>>>
>>> I went through your list and am comfortable with it.
>>>
>>>> About the second, here is the list that I have gathered:
>>>
>>>> - remove the xooki plugin
>>>> - remove the menu generator
>>>> - remove the eadoc plugin
>>>> - remove the docbook plugin
>>>
>>> "provide a XY plugin" makes an excelent feature requests in JIRA.
>>>
>>> Stefan
>>>
>>
>>
>>
>> --
>> Jean Louis Boudart
>> Independent consultant
>> Apache EasyAnt commiter http://incubator.apache.org/easyant/
>
Re: Clean up of some IP issues
Posted by Nicolas Lalevée <ni...@hibnet.org>.
I would like to start clean up the things everybody has agrees on or there is no question about it.
So unless some has some objection, I will:
- get rid of everything under src/integration-test
- remove the menu generator
- remove the eadoc plugin
- remove the docbook plugin
- get rid of the patch of antunit and ivy
- get rid of src/test/antunit
- get rid of the plugins antunit, coverage, cobertura, emma
I'll look closer to the remaining code to clean.
Nicolas
Le 28 juil. 2011 à 15:26, Jean-Louis Boudart a écrit :
> I've just created a few JIRAs related on all this stuff, as Stefan
> suggested.
>
> Le 28 juillet 2011 14:36, Stefan Bodewig <bo...@apache.org> a écrit :
>
>> On 2011-07-27, Nicolas Lalevée wrote:
>>
>>> Then there are the commits which cannot be kept and can be easily
>>> reverted.
>>
>>> And finally the commits I don't know what to do about because they
>>> seems quite important to easyant but there's some IP on it I think.
>>
>> My suggestion would be to open JIRAs for all things that have to be
>> reverted and that you still want to keep as part of EasyAnt in some way.
>> That way others can jump in and provide an implementation of their own.
>>
>> For example if you have a JIRA that says "the shell script fails doing
>> FOO if ANT_HOME isn't set", then all that is required is some bash
>> knowledge and no deep understanding of EasyAnt and even I might be able
>> to contribute.
>>
>> If the contribution is significant, there is no way other than to
>> revert/remove it and have anybody else provide a different approach.
>> The earlier we do this, the easier it is going to be.
>>
>>> So about the first category, I think the mentors should review the
>>> part of the diff about these commits, see the attached
>>> diff-to-keep.txt.
>>
>> I went through your list and am comfortable with it.
>>
>>> About the second, here is the list that I have gathered:
>>
>>> - remove the xooki plugin
>>> - remove the menu generator
>>> - remove the eadoc plugin
>>> - remove the docbook plugin
>>
>> "provide a XY plugin" makes an excelent feature requests in JIRA.
>>
>> Stefan
>>
>
>
>
> --
> Jean Louis Boudart
> Independent consultant
> Apache EasyAnt commiter http://incubator.apache.org/easyant/
Re: Clean up of some IP issues
Posted by Jean-Louis Boudart <je...@gmail.com>.
I've just created a few JIRAs related on all this stuff, as Stefan
suggested.
Le 28 juillet 2011 14:36, Stefan Bodewig <bo...@apache.org> a écrit :
> On 2011-07-27, Nicolas Lalevée wrote:
>
> > Then there are the commits which cannot be kept and can be easily
> > reverted.
>
> > And finally the commits I don't know what to do about because they
> > seems quite important to easyant but there's some IP on it I think.
>
> My suggestion would be to open JIRAs for all things that have to be
> reverted and that you still want to keep as part of EasyAnt in some way.
> That way others can jump in and provide an implementation of their own.
>
> For example if you have a JIRA that says "the shell script fails doing
> FOO if ANT_HOME isn't set", then all that is required is some bash
> knowledge and no deep understanding of EasyAnt and even I might be able
> to contribute.
>
> If the contribution is significant, there is no way other than to
> revert/remove it and have anybody else provide a different approach.
> The earlier we do this, the easier it is going to be.
>
> > So about the first category, I think the mentors should review the
> > part of the diff about these commits, see the attached
> > diff-to-keep.txt.
>
> I went through your list and am comfortable with it.
>
> > About the second, here is the list that I have gathered:
>
> > - remove the xooki plugin
> > - remove the menu generator
> > - remove the eadoc plugin
> > - remove the docbook plugin
>
> "provide a XY plugin" makes an excelent feature requests in JIRA.
>
> Stefan
>
--
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://incubator.apache.org/easyant/
Re: Clean up of some IP issues
Posted by Stefan Bodewig <bo...@apache.org>.
On 2011-07-27, Nicolas Lalevée wrote:
> Then there are the commits which cannot be kept and can be easily
> reverted.
> And finally the commits I don't know what to do about because they
> seems quite important to easyant but there's some IP on it I think.
My suggestion would be to open JIRAs for all things that have to be
reverted and that you still want to keep as part of EasyAnt in some way.
That way others can jump in and provide an implementation of their own.
For example if you have a JIRA that says "the shell script fails doing
FOO if ANT_HOME isn't set", then all that is required is some bash
knowledge and no deep understanding of EasyAnt and even I might be able
to contribute.
If the contribution is significant, there is no way other than to
revert/remove it and have anybody else provide a different approach.
The earlier we do this, the easier it is going to be.
> So about the first category, I think the mentors should review the
> part of the diff about these commits, see the attached
> diff-to-keep.txt.
I went through your list and am comfortable with it.
> About the second, here is the list that I have gathered:
> - remove the xooki plugin
> - remove the menu generator
> - remove the eadoc plugin
> - remove the docbook plugin
"provide a XY plugin" makes an excelent feature requests in JIRA.
Stefan