You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zihao Ye (Code Review)" <ge...@cloudera.org> on 2023/12/14 08:53:10 UTC
[Impala-ASF-CR] IMPALA-12581: Fix issue of ILIKE and IREGEXP not working correctly with non-const pattern
Hello Peter Rozsa, Wenzhe Zhou, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20785
to look at the new patch set (#3).
Change subject: IMPALA-12581: Fix issue of ILIKE and IREGEXP not working correctly with non-const pattern
......................................................................
IMPALA-12581: Fix issue of ILIKE and IREGEXP not working correctly with non-const pattern
This patch fixes the issue where ILIKE and IREGEXP couldn't ignore case
when encountering non-constant patterns.
For example, 'SELECT 'ABC' ILIKE pattern FROM tbl' would return false
when the pattern in tbl is '%b%'.
Tests:
- Add TestNonConstPatternILike to test_exprs.py to verify the
effectiveness of the fixing.
Change-Id: I3d66680f5a7660e6a41859754c4230f276e66712
---
M be/src/exprs/like-predicate.cc
M be/src/exprs/like-predicate.h
M tests/query_test/test_exprs.py
3 files changed, 38 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/20785/3
--
To view, visit http://gerrit.cloudera.org:8080/20785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d66680f5a7660e6a41859754c4230f276e66712
Gerrit-Change-Number: 20785
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>